Skip to content

fix: do open editor of new xblock when duplicating #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

DanielVZ96
Copy link
Contributor

@DanielVZ96 DanielVZ96 commented May 21, 2025

backport of #1887 and #1838

@openedx-webhooks
Copy link

Thanks for the pull request, @DanielVZ96!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 21, 2025
@DanielVZ96 DanielVZ96 changed the title fix: do open editor of new xblock when duplicating (#1887) fix: do open editor of new xblock when duplicating May 21, 2025
Fixes bug where after duplicating an xblock, the editor modal of the old xblock is being open instead of the new copied xblock.
@DanielVZ96 DanielVZ96 force-pushed the dvz/teak/fix-mfe-modals branch from a8fd981 to 4b4575e Compare May 21, 2025 15:16
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/teak@1919eb4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/course-unit/xblock-container-iframe/index.tsx 95.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/teak    #2017   +/-   ##
===============================================
  Coverage                ?   93.83%           
===============================================
  Files                   ?     1147           
  Lines                   ?    24004           
  Branches                ?     5195           
===============================================
  Hits                    ?    22524           
  Misses                  ?     1403           
  Partials                ?       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV
Copy link
Contributor

Hi @DanielVZ96 this PR also includes #1838, is that what is expected?

@DanielVZ96
Copy link
Contributor Author

@ChrisChV yes! I noticed that wasn't backported. I'll update the ticket description. (cc @pomegranited can you confirm this should be backported)

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pomegranited pomegranited requested a review from ChrisChV May 22, 2025 01:27
@pomegranited
Copy link
Contributor

Yes thank you for backporting this @DanielVZ96 , the original #1644 was expected to be done for Teak, and this fix resolves issues introduced with that change, so it can be backported too.

@ChrisChV ChrisChV merged commit 944d131 into openedx:release/teak May 22, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants