-
Notifications
You must be signed in to change notification settings - Fork 119
fix: do open editor of new xblock when duplicating #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do open editor of new xblock when duplicating #2017
Conversation
Thanks for the pull request, @DanielVZ96! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Fixes bug where after duplicating an xblock, the editor modal of the old xblock is being open instead of the new copied xblock.
a8fd981
to
4b4575e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/teak #2017 +/- ##
===============================================
Coverage ? 93.83%
===============================================
Files ? 1147
Lines ? 24004
Branches ? 5195
===============================================
Hits ? 22524
Misses ? 1403
Partials ? 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @DanielVZ96 this PR also includes #1838, is that what is expected? |
@ChrisChV yes! I noticed that wasn't backported. I'll update the ticket description. (cc @pomegranited can you confirm this should be backported) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this on my devstack using the test instructions from fix: do open editor of new xblock when duplicating #1887 and feat: display editors as modals #1838
- I read the commits to check that they match the original merged PRs.
Yes thank you for backporting this @DanielVZ96 , the original #1644 was expected to be done for Teak, and this fix resolves issues introduced with that change, so it can be backported too. |
backport of #1887 and #1838