-
Notifications
You must be signed in to change notification settings - Fork 122
fix: do open editor of new xblock when duplicating #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do open editor of new xblock when duplicating #1887
Conversation
Thanks for the pull request, @DanielVZ96! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1887 +/- ##
==========================================
+ Coverage 93.77% 93.80% +0.02%
==========================================
Files 1146 1154 +8
Lines 23898 24106 +208
Branches 5042 5104 +62
==========================================
+ Hits 22411 22612 +201
- Misses 1419 1426 +7
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
moving this to draft as we may need some changes to support video gallery based on openedx/edx-platform#36641 (comment) |
This reverts commit 40f3b49.
@DanielVZ96 It's ok to fix just the block duplication issues here, and use a separate PR for the video gallery fixes. Duplicate.block.iframe.in.iframe.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is working! Thank you @DanielVZ96 .
- I tested this on my tutor dev stack with fix: open mfe modal editor of new duplicated xblock edx-platform#36641
- duplicated blocks in a course -- opens a modal to edit the duplicated block.
- with
new_core_editors.use_video_gallery_flow
flag enabled, created a video block, and ensured the video gallery is shown. I couldn't test the full edx-val pipeline on my local dev stack, though. - with
new_core_editors.use_video_gallery_flow
flag disabled, created a video block, and ensured the normal video editing modal is shown.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added some comments
Fixes bug where after duplicating an xblock, the editor modal of the old xblock is being open instead of the new copied xblock.
Fixes bug where after duplicating an xblock, the editor modal of the old xblock is being open instead of the new copied xblock.
Description
Fixes bug where after duplicating an xblock, the editor modal of the old xblock is being open instead of the new copied xblock.
Supporting information
Testing instructions
Other information
Private-ref