feat: display editors as modals

[DanielVZ96]

Description

Currently in libraries editing a component opens a modal without navigating into other urls, but in course units you get redirected to a new page to edit the block and then back to the unit page.

This PRs refactors the logic so that editing components in courses opens modals instead of redirecting.. Currently it is keeping the editing urls in order to not break any other flows such as the video upload page.

Supporting information

Issue: #1644

Testing instructions

1. make sure you are using MFE editors: tutor dev run lms ./manage.py lms shell -c "from waffle.models import Flag; Flag.objects.update_or_create(name='contentstore.new_studio_mfe.use_new_unit_page', defaults={'everyone': True})"
2. In any course, create components of multiple types and make sure they can be added and edited correctly
3. Pay special attention to the video editor which has multiple steps in the video creation/edit workflow.

Other information

Private-Ref

[openedx-webhooks]

Thanks for the pull request, @DanielVZ96!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (b30a1c8) to head (0e4d1be).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
+ Coverage   93.77%   93.78%   +0.01%     
==========================================
  Files        1146     1146              
  Lines       23905    23898       -7     
  Branches     5043     5160     +117     
==========================================
- Hits        22416    22412       -4     
+ Misses       1421     1409      -12     
- Partials       68       77       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pomegranited]

Hi @DanielVZ96 The VideoEditor code was much more complicated than it needed to be -- the VideoGallery and VideoSelectors are only used in the Content > Video page, not when editing VideoXBlocks. So I reverted changes to that code.

This is working now, but there are a couple bugs we'll need to fix as part of follow-up PRs:

1. Duplicating a block opens the block editor, but shows page not found.
2. The course optimizer helper relies on the editor page endpoints removed here.
   So we need another way to trigger the editor modal for a given block.

👍

• I tested this by adding and editing all the default and advanced types of XBlocks.
• I read through the code
• I checked for accessibility issues by using my keyboard to navigate
• Includes documentation
• User-facing strings are extracted for translation

[ChrisChV]

This is working now, but there are a couple bugs we'll need to fix as part of follow-up PRs:

• Duplicating a block opens the block editor, but shows page not found.

I made a small fix in 9161f92, the editor is now displayed, but I found the following bugs:

• The editor points to the block being duplicated, not the block that has just been created. But this bug already existed before these changes.
• The new block editor opens as a template inside the iframe. This issue also existed before these changes.

I agree that they can be done in part as a follow-up PR.

CC @DanielVZ96