refactor: remove references of ENABLE_HOME_PAGE_COURSE_API_V2

[bra-i-am]

Description

This PR primarily aims to eliminate references to ENABLE_HOME_PAGE_COURSE_API_V2: it intends to use that API, enabling the pagination and the course filters by default without needing the flag. Moreover, it also solves some issues related to the requests to the API that make the UI blink or request more times than required.

Supporting information

https://github.com/eduNEXT/consulting-issues-mapping/issues/118

Side effects

• The Archived Courses Tab has been removed as it is no longer necessary because it relied on the previously used attribute archived_courses, which is no longer in use. With the implementation of the courses API v2, courses are marked as archived when the isActive attribute of the retrieved courses is true, as reviewed through the new filters.

Testing instructions

1. Mount this MFE on this specific branch in a Sumac/Nightly environment

2. Be sure you count with many courses (11 makes to appear the pagination component)

3. You should watch by default the search bar and filters without adding any env variable

   

4. Open the inspect and go to the Network tab, every time you change the search bar input or change any filter, you should see only one endpoint call is made

[openedx-webhooks]

Thanks for the pull request, @bra-i-am!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.99%. Comparing base (fffa9e2) to head (5615b98).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
src/studio-home/tabs-section/courses-tab/index.tsx	83.33%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #1611    +/-   ##
========================================
  Coverage   93.99%   93.99%            
========================================
  Files        1155     1154     -1     
  Lines       24177    24144    -33     
  Branches     5119     5220   +101     
========================================
- Hits        22724    22695    -29     
+ Misses       1385     1372    -13     
- Partials       68       77     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mariajgrimaldi]

@bradenmacdonald: Can you help us review this PR which is part of the openedx/public-engineering#287 deprecation effort? Thank you!

[bradenmacdonald]

• The Archived Courses Tab has been removed as it is no longer necessary because it relied on the previously used attribute archived_courses, which is no longer in use. With the implementation of the courses API v2, courses are marked as archived when the isActive attribute of the retrieved courses is true, as reviewed through the new filters.
• Taking into account the conditional from courses-tab, should only be displayed when isEnablePagination is false. Since it cannot currently function this way, I assume this feature should be dropped. I wasn't able to make this work without hardcoding (I’m not sure if I'm doing something wrong or if the feature is not functioning). However, based on my review of the code, when a course is executed for re-run, it should transition to a in_process state, which I believe represents a background task, and this is indicated on the front end through the ProcessingCourses component. I’m unclear whether the element should be rendered or not with the new features (I didn't quite understand it), but currently, when the re-run is initiated, the user is redirected to a new route with its own loader button indicating the action being processed. Do you happen to know if this feature should be skipped or how I can get this to work for testing? Should we work this on another PR?

Hmm, I don't think I'll be able to answer these questions. Maybe @jristau1984 or @KristinAoki can answer?

[KristinAoki]

I think the ProcessingCourses component work should be moved to another PR. I have only seen it one time when a course creation job was hung. I am unable to say if it should be skipped or not. If you want to see the feature, you can manually force a course be in-progress by hard-coding the status.

[bra-i-am]

I think the ProcessingCourses component work should be moved to another PR.

@KristinAoki, taking this into account, I removed the ProcessingCourses related changes from this merge request and left only the related with dropping ENABLE_HOME_PAGE_COURSE_API_V2

[saadyousafarbi]

@bra-i-am checking in on this PR. What is the current status of this PR?

I am working on removing the v1 API from edx-platform in this PR, and was wondering when we would be able to merge that PR!
Thanks!

cc: @mariajgrimaldi

[mphilbrick211]

Hi @saadyousafarbi and @bra-i-am! Is this still in progress?

[bra-i-am]

@saadyousafarbi, I'm really really sorry... I didn't see your comment before 🙏

answering you and @mphilbrick211, I already made the required changes, and I think this PR is ready

I am waiting for review

[bradenmacdonald]

A couple minor requests. Also can you please rebase this? It seems a bit old at this point. Then I'll test and approve, and we can get it merge. Thanks!

[bra-i-am]

@bradenmacdonald,

I apologize; it was just a bit outdated 😅. I have already addressed your comments, and I believe this is ready.

Thank you so much for your review! ✨

[bradenmacdonald]

Looks good! Thanks a lot for removing this flag and for fixing those a11y issues so quickly.