-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use current video editor in Libraries #1092
Comments
In scope: Support for youtube sourced videos Expected behavior: When a user tries to embed a video from a non-youtube source, a message displays that indicates "This video source is not yet supported." |
@jmakowski1123 This is ready for testing on the sandbox. I'm not sure what non-youtube video sources are in use, but for now the behavior of the editor should be identical to the behavior in courses, other than not supporting transcripts and not supporting 2U's video manager. If you can find something that works in courses but doesn't work in the library, please let me know. |
I'm not familiar with that feature, but I think that's a reasonable assumption, yep.
It's easy for me to hide those fields, but I'm not sure how to make sure we do that without interfering with 2U (i.e. I'm not sure how we can detect when to show them). And the code is not strictly used for edx.org. Some actions in the platform do result in an auto-generated "video ID" showing up in that field. So the answer is "it's complicated" and I'm not sure we have bandwidth to resolve before MVP unless it's a high priority. I agree those changes make sense though. In fact, we should really just replace the whole video block with a new simple one and let 2U have a separate 2UVideo component that supports their workflow. Having them mushed together makes everything so complicated.
I'm not sure, but I assume it mostly affects the mobile app, which has a feature for downloading videos so you can later learn offline. @kdmccormick do you know if that setting can be overridden, and/or if we can make it overrideable by adding it to our allowlist?
Yes. Though we may also be able to get some basic transcript support over the line, given Dave's rapid progress with static assets. I can plan to put a banner there if not, though. |
From a Library-reference perspective it's trivial to mark the field as customizable, but I don't know whether the field has any video-specific impacts which would make customizing it a bad idea. |
@kdmccormick By customizable, you mean possible to be overridden at the course level? |
@jmakowski1123 Yes |
"As a Library Author, I expect to have the exact same experience when creating and editing videos in Libraries as I do in Courses."
Libraries utilize the same video editor as courses.
The Video Editor can be accessed from the following places in the UI:
When I click the "new button" and the "add content sidebar" opens and I click on "Video", then the video editor modal pops up and I can create a new video component
In the component card, when I click on the 3-dot menu and then when I click on "edit" in the 3 dot menu, then the video editor for that component pops up, and I can make edits or adjustments to that video
In the header of the component sidebar, when I click on the "edit" button, then the video editor for that component pops up, and I can make edits or adjustments to that video
The text was updated successfully, but these errors were encountered: