Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current video editor in Libraries #1092

Closed
jmakowski1123 opened this issue Jun 11, 2024 · 7 comments
Closed

Use current video editor in Libraries #1092

jmakowski1123 opened this issue Jun 11, 2024 · 7 comments

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Jun 11, 2024

"As a Library Author, I expect to have the exact same experience when creating and editing videos in Libraries as I do in Courses."

Libraries utilize the same video editor as courses.

The Video Editor can be accessed from the following places in the UI:

When I click the "new button" and the "add content sidebar" opens and I click on "Video", then the video editor modal pops up and I can create a new video component

In the component card, when I click on the 3-dot menu and then when I click on "edit" in the 3 dot menu, then the video editor for that component pops up, and I can make edits or adjustments to that video

In the header of the component sidebar, when I click on the "edit" button, then the video editor for that component pops up, and I can make edits or adjustments to that video

Image

Image

Image

@jmakowski1123
Copy link
Author

In scope: Support for youtube sourced videos
Out of scope: Support for videos from other sources

Expected behavior: When a user tries to embed a video from a non-youtube source, a message displays that indicates "This video source is not yet supported."

@bradenmacdonald
Copy link
Contributor

@jmakowski1123 This is ready for testing on the sandbox. I'm not sure what non-youtube video sources are in use, but for now the behavior of the editor should be identical to the behavior in courses, other than not supporting transcripts and not supporting 2U's video manager. If you can find something that works in courses but doesn't work in the library, please let me know.

@jmakowski1123
Copy link
Author

jmakowski1123 commented Sep 30, 2024

Thanks Braden. This is working perfectly fine for an MVP.

Couple of questions that are likely out of scope for now, but I want to understand the complexities involved:

  1. I assume the feature to associate a handout (which you can do in courses) can be implemented once static assets are working?
  2. What would it take to remove the edx specific stuff from the block? Things like the "video source id from edx" field, and the multiple references to edx in the descriptor text fields. And if we make those changes, would they apply to the block in both courses and libraries?
  3. What are the implications of choosing the "allow video downloads" box? Assuming that configuration will carry over to whichever courses are using the video? Can it be overriden at the course level?
  4. I'm thinking through the best way to communicate that transcripts aren't supported yet and whether it's possible to do that in platform. It's a little confusing to see the message that no transcript has been uploaded, and then to scroll down and not see a place to add any. We'll obviously cover it in the documentation, but is it possible to change that little descriptor text space to say "Transcripts not yet supported, but will be soon." Or a little banner?
Screen Shot 2024-09-30 at 3 18 59 PM

@bradenmacdonald
Copy link
Contributor

@jmakowski1123

I assume the feature to associate a handout (which you can do in courses) can be implemented once static assets are working?

I'm not familiar with that feature, but I think that's a reasonable assumption, yep.

What would it take to remove the edx specific stuff from the block? Things like the "video source id from edx" field, and the multiple references to edx in the descriptor text fields. And if we make those changes, would they apply to the block in both courses and libraries?

It's easy for me to hide those fields, but I'm not sure how to make sure we do that without interfering with 2U (i.e. I'm not sure how we can detect when to show them). And the code is not strictly used for edx.org. Some actions in the platform do result in an auto-generated "video ID" showing up in that field. So the answer is "it's complicated" and I'm not sure we have bandwidth to resolve before MVP unless it's a high priority. I agree those changes make sense though. In fact, we should really just replace the whole video block with a new simple one and let 2U have a separate 2UVideo component that supports their workflow. Having them mushed together makes everything so complicated.

What are the implications of choosing the "allow video downloads" box? Assuming that configuration will carry over to whichever courses are using the video? Can it be overriden at the course level?

I'm not sure, but I assume it mostly affects the mobile app, which has a feature for downloading videos so you can later learn offline. @kdmccormick do you know if that setting can be overridden, and/or if we can make it overrideable by adding it to our allowlist?

I'm thinking through the best way to communicate that transcripts aren't supported yet and whether it's possible to do that in platform. It's a little confusing to see the message that no transcript has been uploaded, and then to scroll down and not see a place to add any. We'll obviously cover it in the documentation, but is it possible to change that little descriptor text space to say "Transcripts not yet supported, but will be soon." Or a little banner?

Yes. Though we may also be able to get some basic transcript support over the line, given Dave's rapid progress with static assets. I can plan to put a banner there if not, though.

@kdmccormick
Copy link
Member

kdmccormick commented Oct 2, 2024

What are the implications of choosing the "allow video downloads" box? Assuming that configuration will carry over to whichever courses are using the video? Can it be overriden at the course level?

I'm not sure, but I assume it mostly affects the mobile app, which has a feature for downloading videos so you can later learn offline. @kdmccormick do you know if that setting can be overridden, and/or if we can make it overrideable by adding it to our allowlist?

From a Library-reference perspective it's trivial to mark the field as customizable, but I don't know whether the field has any video-specific impacts which would make customizing it a bad idea.

@jmakowski1123
Copy link
Author

@kdmccormick By customizable, you mean possible to be overridden at the course level?

@kdmccormick
Copy link
Member

@jmakowski1123 Yes

@bradenmacdonald bradenmacdonald closed this as completed by moving to Done in Libraries Overhaul Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants