Skip to content

Commit 6456ccc

Browse files
committed
refactor: revert deletion of isShowProcessing
1 parent c6b6c64 commit 6456ccc

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

src/studio-home/StudioHome.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ const StudioHome = () => {
3535
isLoadingPage,
3636
isFailedLoadingPage,
3737
studioHomeData,
38+
isShowProcessing,
3839
anyQueryIsFailed,
3940
isShowEmailStaff,
4041
anyQueryIsPending,
@@ -150,6 +151,7 @@ const StudioHome = () => {
150151
<TabsSection
151152
showNewCourseContainer={showNewCourseContainer}
152153
onClickNewCourse={() => setShowNewCourseContainer(true)}
154+
isShowProcessing={isShowProcessing && !isFiltered}
153155
librariesV1Enabled={librariesV1Enabled}
154156
librariesV2Enabled={librariesV2Enabled}
155157
/>

src/studio-home/tabs-section/courses-tab/index.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import CoursesTab from '.';
1313
import { studioHomeCoursesRequestParamsDefault } from '../../data/slice';
1414

1515
const onClickNewCourse = jest.fn();
16+
const isShowProcessing = false;
1617
const isLoading = false;
1718
const isFailed = false;
1819
const numPages = 1;
@@ -40,6 +41,7 @@ const renderComponent = (overrideProps = {}, studioHomeState = {}) => {
4041
coursesDataItems={studioHomeMock.courses}
4142
showNewCourseContainer={showNewCourseContainer}
4243
onClickNewCourse={onClickNewCourse}
44+
isShowProcessing={isShowProcessing}
4345
isLoading={isLoading}
4446
isFailed={isFailed}
4547
numPages={numPages}
@@ -102,7 +104,7 @@ describe('<CoursesTab />', () => {
102104
});
103105

104106
it('should render CollapsibleStateWithAction when courseCreatorStatus is true', () => {
105-
const props = { isEnabledPagination: false };
107+
const props = { isShowProcessing: true, isEnabledPagination: false };
106108
const customStoreData = {
107109
studioHomeData: {
108110
inProcessCourseActions: [],

src/studio-home/tabs-section/courses-tab/index.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import CardItem from '../../card-item';
1919
import CollapsibleStateWithAction from '../../collapsible-state-with-action';
2020
import ContactAdministrator from './contact-administrator';
2121
import CoursesFilters from './courses-filters';
22+
import ProcessingCourses from '../../processing-courses';
2223
import { LoadingSpinner } from '../../../generic/Loading';
2324
import AlertMessage from '../../../generic/alert-message';
2425
import messages from '../messages';
@@ -37,6 +38,7 @@ interface Props {
3738
}[];
3839
showNewCourseContainer: boolean;
3940
onClickNewCourse: () => void;
41+
isShowProcessing: boolean;
4042
isLoading: boolean;
4143
isFailed: boolean;
4244
numPages: number;
@@ -47,6 +49,7 @@ const CoursesTab: React.FC<Props> = ({
4749
coursesDataItems,
4850
showNewCourseContainer,
4951
onClickNewCourse,
52+
isShowProcessing,
5053
isLoading,
5154
isFailed,
5255
numPages = 0,
@@ -118,6 +121,7 @@ const CoursesTab: React.FC<Props> = ({
118121
) : (
119122
<div className="courses-tab-container">
120123
<div className="d-flex flex-row align-items-center justify-content-between my-4">
124+
{isShowProcessing && <ProcessingCourses />}
121125
<CoursesFilters dispatch={dispatch} locationValue={locationValue} isLoading={isLoading} />
122126
<p data-testid="pagination-info" className="my-0">
123127
{intl.formatMessage(messages.coursesPaginationInfo, {

src/studio-home/tabs-section/index.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import { fetchLibraryData } from '../data/thunks';
2222
const TabsSection = ({
2323
showNewCourseContainer,
2424
onClickNewCourse,
25+
isShowProcessing,
2526
librariesV1Enabled,
2627
librariesV2Enabled,
2728
}) => {
@@ -91,6 +92,7 @@ const TabsSection = ({
9192
coursesDataItems={courses}
9293
showNewCourseContainer={showNewCourseContainer}
9394
onClickNewCourse={onClickNewCourse}
95+
isShowProcessing={isShowProcessing}
9496
isLoading={isLoadingCourses}
9597
isFailed={isFailedCoursesPage}
9698
numPages={numPages}
@@ -178,6 +180,7 @@ const TabsSection = ({
178180
TabsSection.propTypes = {
179181
showNewCourseContainer: PropTypes.bool.isRequired,
180182
onClickNewCourse: PropTypes.func.isRequired,
183+
isShowProcessing: PropTypes.bool.isRequired,
181184
librariesV1Enabled: PropTypes.bool,
182185
librariesV2Enabled: PropTypes.bool,
183186
};

0 commit comments

Comments
 (0)