fix: remove edX support URL from login page #28577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins run python |
waheedahmed
reviewed
Aug 31, 2021
zainab-amir
force-pushed
the
zamir/VAN-710/fix_support_url
branch
from
6040a77 to
4f7748f
Compare
|
Your PR has finished running tests. There were no failures. |
waheedahmed
approved these changes
Aug 31, 2021
nedbat
approved these changes
Aug 31, 2021
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This line: https://github.com/edx/edx-platform/blob/master/lms/static/js/student_account/views/LoginView.js#L235 is a link to the edX support site. This appears on any Open edX site, sending learners from those sites to edX's support channels, where they cannot get help.
get_value. The expectation from these lines in the function is that it should throw an exception if default is not a dictionary:This however doesn't work for empty strings, instead running
dict()on default with empty string value returns{}. Empty dictionary is then returned from the function which is the expected value.Supporting information
Ticket: https://openedx.atlassian.net/browse/VAN-710
Testing instructions
Tested locally by setting support url
Edit: Added a unit test for
get_value()method