Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openedx/edx-platform
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master@{1day}
Choose a base ref
...
head repository: openedx/edx-platform
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 13 commits
  • 17 files changed
  • 6 contributors

Commits on Aug 12, 2025

  1. build: Unpin DRF.

    There have been no breaking changes in the minor versions and there is
    no ticket for unpinning this constraint. It doesn't make sense to keep.
    feanil committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    4d7c8a3 View commit details
    Browse the repository at this point in the history
  2. build: urllib3 is only a testing direct requirement.

    It's only used by botocore and requests in the actual retirement code
    and those have been able to handle a newer version of the library for
    quite some time.
    
    urllib3 is directly used in the testing code but not in a way where we
    need to constrain it from being upgraded.
    feanil committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    bcd900e View commit details
    Browse the repository at this point in the history
  3. chore: Run make upgrade

    feanil committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    2edd656 View commit details
    Browse the repository at this point in the history
  4. test: Reduce query count.

    Previously we were doing the following query:
    
    SELECT 1 AS "a" FROM "user_api_userpreference" WHERE ("user_api_userpreference"."key" = 'pref-lang' AND "user_api_userpreference"."user_id" = 1 AND NOT ("user_api_userpreference"."id" = 1)) LIMIT 1
    
    Looking at the middleware, I don't see why this was previously
    happening.
    feanil committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    b370064 View commit details
    Browse the repository at this point in the history
  5. fix: Correct serializer model reference.

    When linking a DRF serializer with a model, you need to link it to the
    model class not an instance of the model.
    
    The newer version of DRF tries to access the model_manager from the
    model here and runs into issues if it's not defined correctly.
    feanil committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    7121d4e View commit details
    Browse the repository at this point in the history
  6. test: Fix notifacitons test for new DRF version.

    DRF was swallowing an underlying error string and providing its own
    which was being checked for here.
    
    See encode/django-rest-framework#8051 for
    details.
    
    The new version fixes that underlying issue and so the test failed.
    
    Rather than checking for the exact string of the 404 which is not
    relevant, we now just verify that the error code associated with the
    request matches the HTTP response. This should make the test more
    resilient to future text changes in the underlying Django function
    `get_object_or_404`
    feanil committed Aug 12, 2025
    Configuration menu
    Copy the full SHA
    bf62862 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2025

  1. Configuration menu
    Copy the full SHA
    9a8dc51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a7bae6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a466b9 View commit details
    Browse the repository at this point in the history
  4. fix: fix timezone utc for 52 (#37199)

    The django.utils.timezone.utc is removed in Django 5.1.
    
    issue: 37151
    mubbsharanwar authored Aug 13, 2025
    Configuration menu
    Copy the full SHA
    b52e72f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #37165 from openedx/feanil/remove_unnecessary_pin

    feanil/remove unnecessary pin
    feanil authored Aug 13, 2025
    Configuration menu
    Copy the full SHA
    2a53e2e View commit details
    Browse the repository at this point in the history
  6. fix: test failure in test_all_languages (#37201)

    * fix: test failure in test_all_languages
    sumair-arbisoft authored Aug 13, 2025
    Configuration menu
    Copy the full SHA
    eb66c5d View commit details
    Browse the repository at this point in the history
  7. fix: Remove assertQuerysetEqual (#37200)

    replace assertQuerysetEqual with assertEqual dut to deprecation in Django 5.2
    mubbsharanwar authored Aug 13, 2025
    Configuration menu
    Copy the full SHA
    ee8b194 View commit details
    Browse the repository at this point in the history
Loading