Skip to content

Commit 930dcb7

Browse files
committed
fix: issues
1 parent ad8a965 commit 930dcb7

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

cms/djangoapps/contentstore/rest_api/v1/serializers/course_waffle_flags.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class CourseWaffleFlagsSerializer(serializers.Serializer):
2828
use_new_textbooks_page = serializers.SerializerMethodField()
2929
use_new_group_configurations_page = serializers.SerializerMethodField()
3030
enable_course_optimizer = serializers.SerializerMethodField()
31-
react_markdown_editor = serializers.SerializerMethodField()
31+
use_react_markdown_editor = serializers.SerializerMethodField()
3232

3333
def get_course_key(self):
3434
"""
@@ -154,9 +154,9 @@ def get_enable_course_optimizer(self, obj):
154154
course_key = self.get_course_key()
155155
return toggles.enable_course_optimizer(course_key)
156156

157-
def get_react_markdown_editor(self, obj):
157+
def get_use_react_markdown_editor(self, obj):
158158
"""
159-
Method to get the react_markdown_editor waffle flag
159+
Method to get the use_react_markdown_editor waffle flag
160160
"""
161161
course_key = self.get_course_key()
162-
return toggles.react_markdown_editor(course_key)
162+
return toggles.use_react_markdown_editor(course_key)

cms/djangoapps/contentstore/rest_api/v1/views/course_waffle_flags.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def get(self, request, course_id=None):
6262
"use_new_certificates_page": true,
6363
"use_new_textbooks_page": true,
6464
"use_new_group_configurations_page": true
65-
"react_markdown_editor": true,
65+
"use_react_markdown_editor": true,
6666
}
6767
```
6868
"""

cms/djangoapps/contentstore/rest_api/v1/views/tests/test_course_waffle_flags.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class CourseWaffleFlagsViewTest(CourseTestCase):
3434
"use_new_certificates_page",
3535
"use_new_textbooks_page",
3636
"use_new_group_configurations_page",
37-
"react_markdown_editor"
37+
"use_react_markdown_editor"
3838
]
3939

4040
other_expected_waffle_flags = ["enable_course_optimizer"]
@@ -74,8 +74,8 @@ def create_waffle_flags(self, flags, enabled=True):
7474
WaffleFlagCourseOverrideModel.objects.create(
7575
waffle_flag=(
7676
f"contentstore.new_studio_mfe.{flag}"
77-
if flag != "react_markdown_editor"
78-
else "contentstore.react_markdown_editor"
77+
if flag != "use_react_markdown_editor"
78+
else "contentstore.use_react_markdown_editor"
7979
),
8080
course_id=self.course.id,
8181
enabled=enabled,
@@ -114,7 +114,6 @@ def test_get_course_waffle_flags_with_course_id(self):
114114
expected_response["use_new_home_page"] = False
115115

116116
response = self.client.get(course_url)
117-
print(expected_response, response.data)
118117
self.assertEqual(response.status_code, status.HTTP_200_OK)
119118
self.assertDictEqual(expected_response, response.data)
120119

cms/djangoapps/contentstore/toggles.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -219,20 +219,17 @@ def use_new_custom_pages(course_key):
219219
"""
220220
return ENABLE_NEW_STUDIO_CUSTOM_PAGES.is_enabled(course_key)
221221

222-
# .. toggle_name: contentstore.react_markdown_editor
222+
# .. toggle_name: contentstore.use_react_markdown_editor
223223
# .. toggle_implementation: CourseWaffleFlag
224224
# .. toggle_default: False
225225
# .. toggle_description: This flag enables the use of the Markdown editor when creating or editing problems in the authoring MFE
226-
# .. toggle_use_cases: temporary
227-
# .. toggle_creation_date: 2025-4-10
228-
# .. toggle_target_removal_date: 2025-8-31
229226
# .. toggle_tickets: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4517232656/Re-enable+Markdown+editing+of+CAPA+problems+to+meet+various+use+cases
230227
# .. toggle_warning:
231228
ENABLE_REACT_MARKDOWN_EDITOR = CourseWaffleFlag(
232-
f'{CONTENTSTORE_NAMESPACE}.react_markdown_editor', __name__)
229+
f'{CONTENTSTORE_NAMESPACE}.use_react_markdown_editor', __name__)
233230

234231

235-
def react_markdown_editor(course_key):
232+
def use_react_markdown_editor(course_key):
236233
"""
237234
Returns a boolean if new studio custom pages mfe is enabled
238235
"""

0 commit comments

Comments
 (0)