Skip to content

Commit 8dd0605

Browse files
fix: fix tests after rebase
1 parent 6b703b4 commit 8dd0605

File tree

3 files changed

+25
-12
lines changed

3 files changed

+25
-12
lines changed

cms/djangoapps/import_from_modulestore/tests/test_helpers.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from unittest.mock import patch
88

99
from lxml import etree
10+
from openedx_learning.api.authoring_models import LearningPackage
1011

1112
from cms.djangoapps.import_from_modulestore import api
1213
from cms.djangoapps.import_from_modulestore.helpers import ImportClient
@@ -51,7 +52,7 @@ def setUp(self):
5152
with self.captureOnCommitCallbacks(execute=True):
5253
self.import_event = api.create_import(
5354
source_key=self.course.id,
54-
learning_package_id=self.library.learning_package.id,
55+
learning_package_id=self.library.learning_package_id,
5556
user_id=self.user.id,
5657
)
5758
self.parser = etree.XMLParser(strip_cdata=False)
@@ -69,7 +70,8 @@ def test_import_from_staged_content(self):
6970

7071
import_client.import_from_staged_content()
7172

72-
self.assertEqual(self.library.learning_package.content_set.count(), len(expected_imported_xblocks))
73+
learning_package = LearningPackage.objects.get(id=self.library.learning_package_id)
74+
self.assertEqual(learning_package.content_set.count(), len(expected_imported_xblocks))
7375

7476
@patch('cms.djangoapps.import_from_modulestore.helpers.ImportClient._process_import')
7577
def test_import_from_staged_content_block_not_found(self, mocked_process_import):
@@ -84,7 +86,8 @@ def test_import_from_staged_content_block_not_found(self, mocked_process_import)
8486

8587
import_client.import_from_staged_content()
8688

87-
self.assertTrue(not self.library.learning_package.content_set.count())
89+
library_learning_package = LearningPackage.objects.get(id=self.library.learning_package_id)
90+
self.assertTrue(not library_learning_package.content_set.count())
8891
mocked_process_import.assert_not_called()
8992

9093
@ddt.data('chapter', 'sequential', 'vertical')
@@ -105,7 +108,8 @@ def test_create_container(self, block_lvl):
105108
container_to_import.display_name
106109
)
107110

108-
self.assertEqual(self.library.learning_package.publishable_entities.count(), 1)
111+
library_learning_package = LearningPackage.objects.get(id=self.library.learning_package_id)
112+
self.assertEqual(library_learning_package.publishable_entities.count(), 1)
109113

110114
def test_create_container_with_xblock(self):
111115
block_usage_id_to_import = str(self.problem.location)
@@ -142,7 +146,8 @@ def test_process_import_with_complicated_blocks(self, block_lvl):
142146
# pylint: disable=protected-access
143147
result = import_client._process_import(block_usage_id_to_import, block_to_import)
144148

145-
self.assertEqual(self.library.learning_package.content_set.count(), len(expected_imported_xblocks))
149+
library_learning_package = LearningPackage.objects.get(id=self.library.learning_package_id)
150+
self.assertEqual(library_learning_package.content_set.count(), len(expected_imported_xblocks))
146151
self.assertEqual(len(result), len(expected_imported_xblocks))
147152
self.assertEqual(self.import_event.publishableentityimport_set.count(), len(expected_imported_xblocks))
148153

@@ -164,7 +169,8 @@ def test_process_import_with_simple_blocks(self, block_type_to_import):
164169
# pylint: disable=protected-access
165170
result = import_client._process_import(block_usage_id_to_import, block_to_import)
166171

167-
self.assertEqual(self.library.learning_package.content_set.count(), len(expected_imported_xblocks))
172+
library_learning_package = LearningPackage.objects.get(id=self.library.learning_package_id)
173+
self.assertEqual(library_learning_package.content_set.count(), len(expected_imported_xblocks))
168174
self.assertEqual(len(result), len(expected_imported_xblocks))
169175
self.assertEqual(self.import_event.publishableentityimport_set.count(), len(expected_imported_xblocks))
170176

@@ -190,7 +196,7 @@ def test_process_import_with_override(self, override):
190196
with self.captureOnCommitCallbacks(execute=True):
191197
new_import_event = api.create_import(
192198
source_key=self.course.id,
193-
learning_package_id=self.library.learning_package.id,
199+
learning_package_id=self.library.learning_package_id,
194200
user_id=self.user.id,
195201
)
196202
new_staged_content = new_import_event.get_staged_content_by_block_usage_id(block_usage_id_to_import)

cms/djangoapps/import_from_modulestore/tests/test_tasks.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
Tests for tasks in import_from_modulestore app.
33
"""
44
from organizations.models import Organization
5+
from openedx_learning.api.authoring_models import LearningPackage
56
from unittest.mock import patch
67

78
from cms.djangoapps.import_from_modulestore.data import ImportStatus
@@ -90,11 +91,13 @@ class TestImportLibraryFromStagedContentTask(ImportCourseToLibraryMixin):
9091
"""
9192

9293
def _is_imported(self, library, xblock):
93-
self.assertTrue(library.learning_package.content_set.filter(text__icontains=xblock.display_name).exists())
94+
library_learning_package = LearningPackage.objects.get(id=library.learning_package_id)
95+
self.assertTrue(library_learning_package.content_set.filter(text__icontains=xblock.display_name).exists())
9496

9597
def test_import_course_staged_content_to_library_task(self):
9698
""" End-to-end test for import_course_staged_content_to_library_task. """
97-
self.assertEqual(self.library.learning_package.content_set.count(), 0)
99+
library_learning_package = LearningPackage.objects.get(id=self.library.learning_package_id)
100+
self.assertEqual(library_learning_package.content_set.count(), 0)
98101
expected_imported_xblocks = [self.problem, self.problem2, self.video, self.video2]
99102
save_legacy_content_to_staged_content_task(self.import_event.uuid)
100103

@@ -111,7 +114,9 @@ def test_import_course_staged_content_to_library_task(self):
111114

112115
for xblock in expected_imported_xblocks:
113116
self._is_imported(self.library, xblock)
114-
self.assertEqual(self.library.learning_package.content_set.count(), len(expected_imported_xblocks))
117+
118+
library_learning_package.refresh_from_db()
119+
self.assertEqual(library_learning_package.content_set.count(), len(expected_imported_xblocks))
115120

116121
@patch('cms.djangoapps.import_from_modulestore.tasks.ImportClient')
117122
def test_import_library_block_not_found(self, mock_import_client):
@@ -151,7 +156,9 @@ def test_cannot_import_staged_content_twice(self):
151156

152157
for xblock in expected_imported_xblocks:
153158
self._is_imported(self.library, xblock)
154-
self.assertEqual(self.library.learning_package.content_set.count(), len(expected_imported_xblocks))
159+
160+
library_learning_package = LearningPackage.objects.get(id=self.library.learning_package_id)
161+
self.assertEqual(library_learning_package.content_set.count(), len(expected_imported_xblocks))
155162

156163
self.import_event.refresh_from_db()
157164
self.assertEqual(self.import_event.status, ImportStatus.IMPORTED)

cms/djangoapps/import_from_modulestore/views/v0/tests/test_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def setUp(self):
4747
with self.captureOnCommitCallbacks(execute=True):
4848
self.import_event = api.create_import(
4949
user_id=self.admin_user.pk,
50-
learning_package_id=self.library.learning_package.id,
50+
learning_package_id=self.library.learning_package_id,
5151
source_key=self.course.id,
5252
)
5353

0 commit comments

Comments
 (0)