This repository was archived by the owner on May 6, 2024. It is now read-only.
fix: My Courses screen detached fragment issue for ViewModel #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamzaIsrar12
requested review from
farhan-arshad-dev and
omerhabib26
and removed request for
omerhabib26
farhan-arshad-dev
approved these changes
Aug 17, 2022
OpenEdXMobile/src/main/java/org/edx/mobile/view/MyCoursesListFragment.kt
Outdated
Show resolved
Hide resolved
farhan-arshad-dev
approved these changes
Aug 17, 2022
Contributor
farhan-arshad-dev
left a comment
farhan-arshad-dev
left a comment
There was a problem hiding this comment.
sqush the commits and merger away.
- App crashes when the learner receives a delayed response from Firebase Remote Config on a detached 'MyCourseListFragment' and tries to initialize the viewModel on it. We will restrict the app from initializing ViewModel on a detached fragment to fix this issue. Fixes: LEARNER-8986
HamzaIsrar12
force-pushed
the
hamza/LEARNER-8986
branch
from
4735e29 to
3a5787f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-8986
App crashes when the learner receives a delayed response from Firebase Remote Config on a detached
MyCourseListFragmentand tries to initialize the viewModel on it. We will restrict the app from initializing ViewModel on a detached fragment to fix this issue.