This repository has been archived by the owner on May 6, 2024. It is now read-only.
feat: Integration of the payment SDK #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set up the app & store for IAPs - No communication will be made with the backend - Hardcoded sample product id. Tapping “upgrade now” brings up the option to make an in-app purchase, Payment can be made “successfully”, and considered complete on receiving a receipt for an IAP. fixes: LEARNER-8429
farhan-arshad-dev
requested review from
omerhabib26,
miankhalid and
HamzaIsrar12
omerhabib26
suggested changes
Sep 27, 2021
| private val logger = Logger(TAG) | ||
|
|
||
| private var RECONNECT_TIMER_START_MILLISECONDS = 1L * 1000L | ||
| private val RECONNECT_MAX_TIME = 3 // retry connect max times |
There was a problem hiding this comment.
IMO, we should update the name according to its use. i.e, RECONNECT_MAX_COUNT
| * | ||
| * This BillingProcessor knows nothing about the application, all necessary information is either | ||
| * passed into the constructor, exported as observable Flows, or exported through callbacks. | ||
| * */ |
There was a problem hiding this comment.
Please add refenence.
Need some doc for all the methods where possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-8429
Tapping “upgrade now” brings up the option to make an in-app purchase, Payment can be made “successfully”, and considered complete on receiving a receipt for an IAP.
Testing
Ref