This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
forked from kubernetes-retired/external-storage
-
Notifications
You must be signed in to change notification settings - Fork 14
Instrument opentracing APIs in provisioner #33
Closed
utkarshmani1997
wants to merge
2
commits into
openebs-archive:release
from
utkarshmani1997:tracing-#1131-implementation
Closed
Instrument opentracing APIs in provisioner #33
utkarshmani1997
wants to merge
2
commits into
openebs-archive:release
from
utkarshmani1997:tracing-#1131-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@utkarshmani1997 .. please split the commits between the vendor update and actual code changes. |
kmova
suggested changes
Feb 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to review the core files with vendor getting updated.
1. Why is this change necessary ? - To implement tracing in provisioner - See issue : openebs/openebs#1131 for more details 2. How does this change address the issue ? - It uses opentacing libraries to implement tracing by using contexts and spans. 3. How to verify this change ? - First bring up jaeger setup on your cluster.See [here](https://github.com/jaegertracing/jaeger-kubernetes/) - Open jaeger UI by getting loadbalancer/nodeport IP on browser. - Run the templates given below ``` apiVersion: apps/v1beta1 kind: Deployment metadata: name: maya-apiserver namespace: default spec: replicas: 1 template: metadata: labels: name: maya-apiserver spec: serviceAccountName: openebs-maya-operator containers: - name: maya-apiserver imagePullPolicy: Always image: utkarshmani1997/m-apiserver:testtracing1 ports: - containerPort: 5656 env: - name: OPENEBS_IO_JIVA_CONTROLLER_IMAGE value: "openebs/jiva:0.5.1-RC1" - name: OPENEBS_IO_JIVA_REPLICA_IMAGE value: "openebs/jiva:0.5.1-RC1" - name: OPENEBS_IO_VOLUME_MONITOR_IMAGE value: "openebs/m-exporter:0.5.0" - name: OPENEBS_IO_JIVA_REPLICA_COUNT value: "2" - image: jaegertracing/jaeger-agent name: jaeger-agent ports: - containerPort: 5775 protocol: UDP - containerPort: 5778 - containerPort: 6831 protocol: UDP - containerPort: 6832 protocol: UDP command: - "/go/bin/agent-linux" - "--collector.host-port=jaeger-collector:14267" --- apiVersion: v1 kind: Service metadata: name: maya-apiserver-service spec: ports: - name: api port: 5656 protocol: TCP targetPort: 5656 selector: name: maya-apiserver sessionAffinity: None --- apiVersion: apps/v1beta1 kind: Deployment metadata: name: openebs-provisioner namespace: default spec: replicas: 1 template: metadata: labels: name: openebs-provisioner spec: serviceAccountName: openebs-maya-operator containers: - name: jaeger-agent imagePullPolicy: Always image: jaegertracing/jaeger-agent ports: - containerPort: 5775 protocol: UDP - containerPort: 5778 - containerPort: 6831 protocol: UDP - containerPort: 6832 protocol: UDP command: - "/go/bin/agent-linux" - "--collector.host-port=jaeger-collector:14267" - name: openebs-provisioner image: utkarshmani1997/openebs-provisioner:testtracing1 env: - name: NODE_NAME valueFrom: fieldRef: fieldPath: spec.nodeName - name: OPENEBS_MONITOR_URL value:"http://127.0.0.1:32515/dashboard/db/openebs-volume-stats?orgId=1" - name: OPENEBS_MONITOR_VOLKEY value: "&var-OpenEBS" - name: MAYA_PORTAL_URL value: "https://mayaonline.io/" ``` 4. What side effects does this change have ? - none 5. Other details - Feature : openebs/openebs#1131 - This is very first and complete PR for the provisioner, there will be more PR that yet be raised in openebs/maya and openebs/jiva for indepth tracing. Signed-off-by: utkarshmani1997 <utkarshmani1997@gmail.com>
Check if kubernetes/enhancements#496 helps get similar metrics. |
We will revisit the tracing PR after moving to CSI plugin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and spans.
here
Note :
more PR that yet be raised in openebs/maya and openebs/jiva for
indepth tracing.
Signed-off-by: utkarshmani1997 utkarshmani1997@gmail.com