-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve workflows #353
Improve workflows #353
Conversation
This PR:
Finally I've spent quite some time trying to get I don't think it's wise or necessary to do this now (especially since single demo grasp will be reworked), but we need to decide whether we should still include these 3 tools in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much Daniel, improvements look great.
I just noticed that protobuf is listed twice in two dependencies files, probably by mistake?
src/opendr/perception/multimodal_human_centric/dependencies.ini
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_detection_3d/voxel_object_detection_3d/dependencies.ini
Outdated
Show resolved
Hide resolved
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…on_3d/dependencies.ini Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 🚀
Thank you Daniel!!! I agree with you regarding the |
Hi @ad-daniel, I am directly changed a few lines to test something - I hope this is fine. I didn't manage to reproduce the issue locally just by installing the package. So, there might be something related to the test setup. One possibility is that setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the manual make commands. This seems to be working, if I didn't miss anything.
I see, I was testing other stuff at the same time, so that is indeed very plausible. Likewise, it wasn't present in the previous version so that could very well be the culprit. Thanks a lot! |
Improves the workflow and fixes issues