Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker, installation and documentation improvements #276

Merged
merged 12 commits into from
Jul 13, 2022

Conversation

passalis
Copy link
Collaborator

@passalis passalis commented Jul 5, 2022

This PR improves docker images and installation process by

  • Removing cache from docker images (about ~3GB size reduction)
  • Reducing the number of intermediate layers created
  • Adding missing ROS packages after building the main dependencies
  • Adding a default argument (master) for branch creation
  • Transferred docker building process into a separate customization section of the documentation

@passalis passalis marked this pull request as draft July 5, 2022 07:42
@passalis passalis changed the title Docker and installation improvements Docker, installation and documentation improvements Jul 5, 2022
@passalis passalis marked this pull request as ready for review July 5, 2022 08:37
@ad-daniel ad-daniel added test sources Run style checks test release Tests if a wheel created from a branch runs correctly labels Jul 11, 2022
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I just have two very minor suggestions to improve the text.

passalis and others added 2 commits July 12, 2022 11:23
Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@passalis passalis merged commit d4dec9a into develop Jul 13, 2022
@passalis passalis deleted the docker_improvements branch July 13, 2022 10:07
passalis added a commit that referenced this pull request Sep 7, 2022
* include 3d detection test

* fix np bool warning

* Revert "fix np bool warning"

This reverts commit ec21061.

* Remove del learner

* Eneable tracking 3d tests

* Add init for 2d tracking tests

* Update 3D tracking dependencies

* Docker, installation and documentation improvements  (#276)

* docker fixes

* Style fixes

* Create customize.md

* Removed docker building instructions

* Update customize.md

* Update customize.md

* Update installation.md

* Update customize.md

* Added link for customization

* Update docs/reference/installation.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/reference/installation.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/reference/installation.md

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

* DetectionDataset evaluation fix for empty detections (#285)

* Checkout specific detectron commit

* Install specific detectron2 commit

* Point to specific detectron2 commit

* Update installation.md

* Update dependencies.ini

* Update dependencies.ini

* Update requirements.txt

* Update dependencies.ini

* Update dependencies.ini

* Update requirements.txt

* Update to support newer skimage version

* Clarified purpose and limitations of fall detection tool (#280)

* Enable All 3d test

* Fix slow data preparation for KITTI

* Simplify 3d detection tests

* Fix unclosed file

* Fix repeated eval failure

* Cleanup

* Cleanup

* Cleanup

* Remove unused test functions

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: vivinousi <32997432+vivinousi@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: ad-daniel <daniel.dias@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test release Tests if a wheel created from a branch runs correctly test sources Run style checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants