Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Max retry attempt should be different among detectors #171

Open
kaituo opened this issue Jun 22, 2020 · 0 comments
Open

Max retry attempt should be different among detectors #171

kaituo opened this issue Jun 22, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@kaituo
Copy link
Member

kaituo commented Jun 22, 2020

Is your feature request related to a problem? Please describe.
Currently, when we encounter EndRunException, we would retry 3 times before terminating. This is not ideal. For example, if detector interval is 1 minute and memory circuit breaker is open, we may not be able to recover within 3 minutes.

Describe the solution you'd like
We should set max retry attempts based on detector interval. Also, the number of allowed retries should be settable per exception object, i.e. the endrun exception contains a field for the number of retries, which can be specific to detector (interval), exception type (limit exceeded, other endrun), or root cause. Stop now being true would just be a special case that number of retries being 0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant