Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curvefs/client: optimize DiskCacheManager::UmountDiskCache() #2252

Merged
merged 1 commit into from
Mar 31, 2023
Merged

curvefs/client: optimize DiskCacheManager::UmountDiskCache() #2252

merged 1 commit into from
Mar 31, 2023

Conversation

Ziy1-Tan
Copy link
Contributor

@Ziy1-Tan Ziy1-Tan commented Feb 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: #1669

Problem Summary:
don't need to call UploadAllCacheWriteFile() twice

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Ziy1-Tan
Copy link
Contributor Author

cicheck

@Ziy1-Tan Ziy1-Tan force-pushed the cache_opt branch 5 times, most recently from dcd8d66 to a5f0794 Compare February 20, 2023 02:33
@Ziy1-Tan
Copy link
Contributor Author

cicheck

@wuhongsong
Copy link
Contributor

there has two goals of UploadAllCacheWriteFile：
1）When client restart, upload the residual object
2) when umount, upload the object that has not been asynchronous upload to s3 after write

@wuhongsong wuhongsong self-requested a review February 22, 2023 02:07
@Ziy1-Tan
Copy link
Contributor Author

cicheck

@Ziy1-Tan Ziy1-Tan force-pushed the cache_opt branch 2 times, most recently from a83f32d to 0580a41 Compare March 1, 2023 12:07
@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 1, 2023

cicheck

1 similar comment
@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 1, 2023

cicheck

@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 2, 2023

cicheck

@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 2, 2023

cc @wuhongsong

@wuhongsong
Copy link
Contributor

LGTM， good job

@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 2, 2023

@ilixiaocui Hi! would you mind to take a look?

@ilixiaocui
Copy link
Contributor

@ilixiaocui Hi! would you mind to take a look?

okay!

@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 9, 2023

cicheck

@Ziy1-Tan
curvefs/client: optimize DiskCacheManager::UmountDiskCache()
974cdce 
Signed-off-by: Ziy1-Tan <ajb459684460@gmail.com>
@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 9, 2023

cicheck

@ilixiaocui
Copy link
Contributor

@wuhongsong Is it okay to review the new plan?

@wuhongsong
Copy link
Contributor

LGTM

@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Mar 23, 2023 •
edited
Loading

@ilixiaocui mind take a look?

@ilixiaocui ilixiaocui merged commit 39a0c11 into opencurve:master Mar 31, 2023
@ilixiaocui
Copy link
Contributor

@ilixiaocui mind take a look?

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cr-gpt cr-gpt[bot] cr-gpt[bot] left review comments

@ilixiaocui ilixiaocui ilixiaocui approved these changes

@wuhongsong wuhongsong wuhongsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ziy1-Tan @wuhongsong @ilixiaocui