specerror: Add NewRFCError and NewRFCErrorOrPanic #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (but I'm not a maintainer) |
liangchenye
reviewed
Apr 19, 2018
specerror/error.go
Outdated
| // NewRFCErrorOrPanic creates an rfc2119.Error referencing a spec | ||
| // violation and panics on failure. This is handy for situations | ||
| // where you can't be bothered to check NewRFCError for failure. | ||
| func NewRFCErrorOrPanic(code Code, err error, version string) (*rfc2119.Error) { |
There was a problem hiding this comment.
go fmt fails at this line.
It should be
func NewRFCErrorOrPanic(code Code, err error, version string) *rfc2119.Error {
liangchenye
reviewed
Apr 19, 2018
validation/state.go
Outdated
| @@ -7,6 +7,7 @@ import ( | |||
| "github.com/mndrix/tap-go" | |||
| rspecs "github.com/opencontainers/runtime-spec/specs-go" | |||
| "github.com/opencontainers/runtime-tools/specerror" | |||
| rfc2119 "github.com/opencontainers/runtime-tools/error" | |||
There was a problem hiding this comment.
go fmt fails at this line.
It should be moved one line up.
rfc2119 "github.com/opencontainers/runtime-tools/error"
"github.com/opencontainers/runtime-tools/specerror"
So we don't have to dance around with casting to extract structured information from NewError's returned error. Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't have to dance around with casting to extract structured information from
NewError's returned error.