runtimetest: fix nil dereference #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
|
In logic, this is a correct fix. But in fact, this is impossible, because if process is nil, the container can not be run. |
|
On Thu, Nov 23, 2017 at 07:07:31AM +0000, Ma Shimiao wrote:
In logic, this is a correct fix. But in fact, this is impossible,
because if process is nil, the container can not be run.
I sometimes call runtimetest in my host environment (i.e. without a
wrapping runtime invocation). This guard will help in that case,
although I'm also fine with panics there, since that's not how
runtimetest is intended to be used. So I have no opinion on this PR,
but maintainers might want to consider that use case when deciding on
it.
|
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com