generate: solve conflicting options problem #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM, |
Mashimiao
force-pushed
the
conflicting-options
branch
from
724da42 to
421d85b
Compare
|
updated, thanks |
Mashimiao
force-pushed
the
conflicting-options
branch
2 times, most recently
from
38cadd0 to
229cef0
Compare
|
LGTM |
Mashimiao
changed the title
Mashimiao
force-pushed
the
conflicting-options
branch
from
229cef0 to
721fbce
Compare
In my option, there is not any other good ways to solve conflicting options problem except adding note for warning. Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my option, there is not any other good ways to solve conflicting
options problem except adding note for warning.
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com