Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: refactor runtime-tools commands #410

Open
hqhq opened this issue Jul 5, 2017 · 4 comments
Open

Proposal: refactor runtime-tools commands #410

hqhq opened this issue Jul 5, 2017 · 4 comments

Comments

@hqhq
Copy link
Contributor

hqhq commented Jul 5, 2017

We use oci-runtime-tool validate to validate bundle and use make localvalidation for runtime validation, it doesn't look ideal to me, what I thought is:

  • oci-runtime-tool generate for config generation
  • oci-runtime-tool validate bundle for bundle validation
  • oci-runtime-tool validate runtime for runtime validation

As the only tool we offer to user is oci-runtime-tool and runtimetest is only an auxiliary binary for runtime validation, I think runtimetest should not be taken as a first class citizen as oci-runtime-tool is. So I think we should move oci-runtime-tool main code to root directory and put runtimetest codes into some sub directories, put them in cmd directory and generate the two binaries in root directory looks like we are offering two tool binaries.

WDYT about this refactoring, I can help working on this if it looks good to you.

@hqhq
Copy link
Contributor Author

hqhq commented Jul 5, 2017

ping @Mashimiao @liangchenye @mrunalp

@liangchenye
Copy link
Member

localvalidation is a temporary solution, runtimetest only partially validate a runtime with the spec.
What we miss is a runtime testing framework which was discussed before and was assigned to me....
It should start/stop/kill a runtime and verify the running status.

I think we can refactor it according to your suggestion after the testing framework been implemented.

@Mashimiao
Copy link

runtimetest is a necessary binary to check container's internal environment. At first we also want something like oci-runtime-tool validate runtime. But as reasons which have been discussed in #336, we decided to use make localvalidation

@Mashimiao
Copy link

But I really prefer to something like oci-runtime-tool validate runtime, if we can solve problems in #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants