Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate errors out if an action is specified that's the same as default #395

Closed
grantseltzer opened this issue Jun 15, 2017 · 1 comment

Comments

@grantseltzer
Copy link
Contributor

For example:

17:33:40 grant in ~> ~ 
[*] oci-runtime-tool generate  --seccomp-default trace --seccomp-trace clone
default action already set as SCMP_ACT_TRACE

Instead, the default should be set to the specified action and a new rule just shouldn't be added specifically for the syscall... then the config should be printed as normal.

Other conflicting rules are just taken into account and generated gracefully. This doc explains the logic. That should probably be moved over to this repo as well.

@Mashimiao
Copy link

That' really a problem, we also have seccomp problem in default template. Maybe we can fix it after solve simple template problem #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants