Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add a trailing period to the "cannot be mapped" rlimits line #915

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

wking
Copy link
Contributor

@wking wking commented Aug 31, 2017

Fixing a typo I'd made in 5292e9c (#880).

I think this is a patch-level change, so it can be tagged v1.0.Z (although we have had a few patch-level PRs merged without adding them to that milestone).

Fixing a typo I'd made in 5292e9c (config: Make rlimits
POSIX-specific, 2017-05-23, opencontainers#880).

Signed-off-by: W. Trevor King <wking@tremily.us>
Copy link

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hqhq
Copy link
Contributor

hqhq commented Sep 1, 2017

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Sep 1, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 689521f into opencontainers:master Sep 1, 2017
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Sep 6, 2017
Through 689521f (Merge pull request opencontainers#915 from wking/rlimits-unmapped-period, 2017-09-01).

There have also been two non-spec changes which I have not documented
in the ChangeLog:

13b4639 .pullapprove.yml: Switch to v2 and other project-template
  updates (opencontainers#902)
f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910)

Signed-off-by: W. Trevor King <wking@tremily.us>
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Sep 6, 2017
Through 689521f (Merge pull request opencontainers#915 from
wking/rlimits-unmapped-period, 2017-09-01).

There have also been two non-spec changes which I have not documented
in the ChangeLog:

13b4639 .pullapprove.yml: Switch to v2 and other project-template
  updates (opencontainers#902)
f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910)

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking deleted the rlimits-unmapped-period branch September 6, 2017 21:46
@vbatts vbatts mentioned this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants