ChangeLog: Document changes since c83b8c8 #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or at best I can pull this commit into the v1.0.0 version bump
…On Mon, Jul 10, 2017, 18:10 W. Trevor King ***@***.***> wrote:
Through f4d221c
<f4d221c>
(Merge pull request #880
<#880>). The rc6
release picked up an earlier version of these notes in b94a1ec
<b94a1ec>,
and those entries are mostly unchanged except for:
- The credentialSpec entry, which was #814
<#814> for
credentialspec and now also includes #859
<#859> for
credentialSpec.
- The root(.path) Hyper-V entry, which was #820
<#820> for root.path
and now also includes #838
<#838> for root. I
also moved this into the “breaking changes” section, because rc5 Hyper-V
configs required root to be set, and rc6 Hyper-V configs require it to
not be set. Although whether rc5 allowed Hyper-V configs at all is not
clear to me.
- Fixed indenting for the typo-fixes entry, as well as a number of
more recent typo-fix PRs.
There are also a number of completely new entries to cover the remaining
changes between c83b8c8
<c83b8c8>
and f4d221c
<f4d221c>
.
I checked
<http://ircbot.wl.linuxfoundation.org/eavesdrop/%23opencontainers/%23opencontainers.2017-07-10.log.html#t2017-07-10T21:14:58>
with @vbatts <https://github.com/vbatts> before filing this PR. I don't
think we need to wait until a 1.0.0 bump for these changes, because we know
what landed in rc6, and there's no reason not to have current docs for that
in master.
------------------------------
You can view, comment on, or merge this pull request online at:
#888
Commit Summary
- ChangeLog: Document changes since c83b8c8
File Changes
- *M* ChangeLog
<https://github.com/opencontainers/runtime-spec/pull/888/files#diff-0>
(47)
Patch Links:
- https://github.com/opencontainers/runtime-spec/pull/888.patch
- https://github.com/opencontainers/runtime-spec/pull/888.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#888>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAEF6XoLHLlTPWF9ftVZR9Lgg6RUxdnGks5sMqFWgaJpZM4OTe5i>
.
|
|
On Mon, Jul 10, 2017 at 10:12:10PM +0000, v1.0.0.batts wrote:
Or at best I can pull this commit into the v1.0.0 version bump
At best? Is there a reason to wait until v1.0.0 instead of landing
this PR to master now? Maybe I missunderstood your IRC comments…
|
ChangeLog
Outdated
| * config: Remove the previously-forbidden mounts[].type from the | ||
| Windows spec (#854) | ||
| * config: Clarify mounts[].source relative path anchor (#735) | ||
| * config: Explicily make consoleSize ignored if terminal is false or |
There was a problem hiding this comment.
nit Explicily to Explicitly (missing 't')
Through f4d221c (Merge pull request opencontainers#880 from dqminh/wking-linux-only-capabilities-again, 2017-07-05). The rc6 release picked up an earlier version of these notes, and those entries are mostly unchanged except for: * The credentialSpec entry, which was opencontainers#814 for credentialspec and now also includes opencontainers#859 for credentialSpec. * The root(.path) Hyper-V entry, which was opencontainers#820 for root.path and now also includes opencontainers#838 for root. I also moved this into the "breaking changes" section, because rc5 Hyper-V configs required root to be set, and rc6 Hyper-V configs require it to not be set. Although whether rc5 allowed Hyper-V configs at all is not clear to me. * Fixed indenting for the typo-fixes entry, as well as a number of more recent typo-fix PRs. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
v1.0.0-rc6-change-log
branch
from
406df0a
to
913d300
Compare
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through f4d221c (Merge pull request #880). The rc6 release picked up an earlier version of these notes in b94a1ec, and those entries are mostly unchanged except for:
credentialSpecentry, which was Windows: Add CredentialSpec #814 forcredentialspecand now also includes Windows: Fix camelCase inconsistencies #859 forcredentialSpec.root(.path)Hyper-V entry, which was Clarify root path #820 forroot.pathand now also includes config: Bump Hyper-V condition from root.path to root itself #838 forroot. I also moved this into the “breaking changes” section, because rc5 Hyper-V configs requiredrootto be set, and rc6 Hyper-V configs require it to not be set. Although whether rc5 allowed Hyper-V configs at all is not clear to me.There are also a number of completely new entries to cover the remaining changes between c83b8c8 and f4d221c.
I checked with @vbatts before filing this PR. I don't think we need to wait until a 1.0.0 bump for these changes, because we know what landed in rc6, and there's no reason not to have current docs for that in master.