Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Fix broken JSON in Windows mount example #738

Merged
merged 1 commit into from
Mar 20, 2017
Merged

config: Fix broken JSON in Windows mount example #738

merged 1 commit into from
Mar 20, 2017

Conversation

wking
Copy link
Contributor

@wking wking commented Mar 16, 2017

The key: value syntax is for objects, but mounts is an array.

@wking
config: Fix broken JSON in Windows mount example
fab8f37 
The 'key: value' syntax is for objects, but 'mounts' is an array.

Signed-off-by: W. Trevor King <wking@tremily.us>
@mrunalp
Copy link
Contributor

mrunalp commented Mar 17, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@hqhq
Copy link
Contributor

hqhq commented Mar 20, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@hqhq hqhq merged commit e659613 into opencontainers:master Mar 20, 2017
@wking wking deleted the broken-mounts-example branch March 28, 2017 20:46
@vbatts vbatts mentioned this pull request May 19, 2017
Closed
@vbatts vbatts mentioned this pull request Jul 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wking @mrunalp @hqhq