Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs-go/config: Make Linux and Solaris omitempty #431

Merged
merged 2 commits into from
May 9, 2016
Merged

specs-go/config: Make Linux and Solaris omitempty #431

merged 2 commits into from
May 9, 2016

Commits on May 7, 2016

  1. config: Add platform-specific entry for 'solaris' 

    Fixup for 7c9daeb (Introducing Solaris in OCI, 2016-04-25, opencontainers#411) along
the lines of b373a15 (config: Split platform-specific configuration
into its own section, 2016-05-02, opencontainers#414).

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed May 7, 2016
    Configuration menu
    Copy the full SHA
    759ee79 View commit details
    Browse the repository at this point in the history

  2. specs-go/config: Make Linux and Solaris omitempty 

    Both fields are optional, so you could conceivably have neither.
However, in most cases folks will populate the one corresponding to
their platform.  The one that *doesn't* match their platform must not
show up, in order to avoid violating the:

  This should only be set if **`platform.os`** is ...

phrasing.

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed May 7, 2016
    Configuration menu
    Copy the full SHA
    5c2193f View commit details
    Browse the repository at this point in the history