config-linux: allow empty strings in memory policy nodes field#1306
Open
askervin wants to merge 1 commit intoopencontainers:mainfrom
Open
config-linux: allow empty strings in memory policy nodes field#1306askervin wants to merge 1 commit intoopencontainers:mainfrom
askervin wants to merge 1 commit intoopencontainers:mainfrom
Conversation
When runtime-tools validator checks mandatory fields, it expects every string field either to be tagged "omitempty" or contain a non-empty string. Linux memory policy modes MPOL_DEFAULT and MPOL_LOCAL must have empty nodes field. This change adds "omitempty" tag to LinuxMemoryPolicy.Nodes in order to pass runtime-tools validation in these modes. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
Contributor
Author
|
@cyphar, when I was testing opencontainers/runtime-tools#786, I noticed that leaving out "omitempty" from LinuxMemoryPolicy.Nodes causes runtime-tools validation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When runtime-tools validator checks mandatory fields, it expects every string field either to be tagged "omitempty" or contain a non-empty string. Linux memory policy modes MPOL_DEFAULT and MPOL_LOCAL must have empty nodes field. This change adds "omitempty" tag to LinuxMemoryPolicy.Nodes in order to pass runtime-tools validation in these modes.