-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camel casing needs fixing in config.go and matching schema #857
Comments
If we're going to adjust any of this casing, I'd *really* like to have
that happen before the next tag. #842 (the proposed rc6, currently at
4e3635b) has:
$ git checkout origin/pr/842
$ git grep '`' -- config-windows.md
…
config-windows.md:* **`sandboxSize`** *(uint64, OPTIONAL)* - specifies the minimum size of the system drive in bytes.
…
config-windows.md:* **`egressBandwidth`** *(uint64, OPTIONAL)* - specified the maximum egress bandwidth in bytes per second for the container.
…
config-windows.md:The `credentialspec` is a JSON object whose properties are implementation-defined.
…
And master has:
$ git checkout origin/master
$ git describe
v1.0.0-rc5-194-g9151c77
$ git grep '`' -- config-windows.md
…
config-windows.md:* **`sandboxSize`** *(uint64, OPTIONAL)* - specifies the minimum size of the system drive in bytes.
…
config-windows.md:* **`endpointList`** *(array of strings, OPTIONAL)* - list of HNS (Host Network Service) endpoints that the container should connect to.
config-windows.md:* **`allowUnqualifiedDNSQuery`** *(bool, OPTIONAL)* - specifies if unqualified DNS name resolution is allowed.
config-windows.md:* **`DNSSearchList`** *(array of strings, OPTIONAL)* - comma seperated list of DNS suffixes to use for name resolution.
config-windows.md:* **`networkSharedContainerName`** *(string, OPTIONAL)* - name (ID) of the container that we will share with the network stack.
…
config-windows.md:The `credentialspec` is a JSON object whose properties are implementation-defined.
…
config-windows.md:* **`utilityvmpath`** *(string, OPTIONAL)* - specifies the path to the image used for the utility VM. This would be specified if using a base image which does not contain a utility VM image. If not supplied, the runtime will search the container filesystem layers from the bottom-most layer upwards, until it locates "UtilityVM", and default to that path.
config-windows.md:* **`sandboxpath`** *(string, REQUIRED)* - specifies the root of the path to the sandbox to be used for the container.
…
which both have camelCase (sandboxSize, etc.) and lowercase
(credentialspec) properties. Casing is a really silly thing to break
backwards compat on. We already have backwards-incompatible changes
post the currently proposed rc6 (e.g. #801), but I'd rather not break
compat again after we cut rc7 (or 1.0, or whatever comes after rc6).
|
Agreed. As soon as that other PR is merged, I'll get on it. |
On Thu, May 25, 2017 at 10:48:13AM -0700, John Howard wrote:
Agreed. As soon as that other PR is merged, I'll get on it.
Maintainers may also want to milestone this issue 1.0 freeze [1] so it
doesn't slide to post-1.0.
[1]: https://github.com/opencontainers/runtime-spec/milestone/15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per this comment: #828 (comment)
The text was updated successfully, but these errors were encountered: