Specs don't build on gccgo

[tonistiigi]

After #343 building with gccgo seems to fail:

22:23:58 + git clone https://github.com/opencontainers/runc.git /tmp/tmp.Mst50n3vK1/src/github.com/opencontainers/runc
22:23:58 Cloning into '/tmp/tmp.Mst50n3vK1/src/github.com/opencontainers/runc'...
22:24:00 + cd /tmp/tmp.Mst50n3vK1/src/github.com/opencontainers/runc
22:24:00 + git checkout -q 0c1c615ebd6a15545b6a82ead01d2745ea49b242
22:24:00 + make static BUILDTAGS=seccomp apparmor selinux
22:24:00 CGO_ENABLED=1 go build -tags "seccomp apparmor selinux cgo static_build" -ldflags "-w -extldflags -static -X main.gitCommit=0c1c615ebd6a15545b6a82ead01d2745ea49b242" -o runc .
22:24:00 go build: when using gccgo toolchain, please pass linker flags using -gccgoflags, not -ldflags
22:24:08 # github.com/pquerna/ffjson/fflib/v1
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s: Assembler messages:
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:6: Error: no such instruction: `text scanStringSSE(SB),NOSPLIT,$0'
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:15: Error: no such instruction: `text ·haveSSE42(SB),NOSPLIT,$0'
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:16: Error: too many memory references for `xor'
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:21: Error: too many memory references for `mov'
22:24:09 Makefile:21: recipe for target 'static' failed
22:24:09 make: *** [static] Error 2

[vbatts]

hrmm
not sure what to say about this. It is kind of out of the scope here but
now that we've brought in ffjson we have to own this...

On Thu, Mar 31, 2016 at 1:41 PM, Tõnis Tiigi notifications@github.com
wrote:

After #343 #343
building with gccgo seems to fail:

22:23:58 + git clone https://github.com/opencontainers/runc.git /tmp/tmp.Mst50n3vK1/src/github.com/opencontainers/runc
22:23:58 Cloning into '/tmp/tmp.Mst50n3vK1/src/github.com/opencontainers/runc'...
22:24:00 + cd /tmp/tmp.Mst50n3vK1/src/github.com/opencontainers/runc
22:24:00 + git checkout -q 0c1c615ebd6a15545b6a82ead01d2745ea49b242
22:24:00 + make static BUILDTAGS=seccomp apparmor selinux
22:24:00 CGO_ENABLED=1 go build -tags "seccomp apparmor selinux cgo static_build" -ldflags "-w -extldflags -static -X main.gitCommit=0c1c615ebd6a15545b6a82ead01d2745ea49b242" -o runc .
22:24:00 go build: when using gccgo toolchain, please pass linker flags using -gccgoflags, not -ldflags
22:24:08 # github.com/pquerna/ffjson/fflib/v1
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s: Assembler messages:
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:6: Error: no such instruction: text scanStringSSE(SB),NOSPLIT,$0' 22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:15: Error: no such instruction:text ·haveSSE42(SB),NOSPLIT,$0'
22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:16: Error: too many memory references for xor' 22:24:08 Godeps/_workspace/src/github.com/pquerna/ffjson/fflib/v1/reader_scan_amd64.s:21: Error: too many memory references formov'
22:24:09 Makefile:21: recipe for target 'static' failed
22:24:09 make: *** [static] Error 2

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#362

[crosbymichael]

Besides gccgo being plain bad we can remove ffjson if you want @vbatts

[wking]

Does #361 fix this? The anonymous structure reflection change in Go
1.6 talks about differences between gc and gccgo 1. I'm also fine
with offloading the ffjson wrapping and Go bindings in general to a
different project that can make their own calls about whether they
support gccgo.

[JakeWarner]

I'm not necessarily sold on incorporating ffjson. Sure it has speed improvements but are we writing to json files enough to warrant introducing another cog to the machine?

[crosbymichael]

I say we just remove it for now

[JakeWarner]

+1 to removing