-
Notifications
You must be signed in to change notification settings - Fork 553
Comparing changes
Open a pull request
base repository: opencontainers/runtime-spec
base: 99a1b8d363f7b14286cf90ab7a080142182a1399
head repository: opencontainers/runtime-spec
compare: 0417be67c8709fad61f34522b367b4e3e7f80143
- 18 commits
- 17 files changed
- 4 contributors
Commits on Apr 5, 2017
-
config: Drop the redundant config.json filename requirement
Because: 1. This section defines the configuration format, and doesn't need to be tied to a particular filename. 2. The bundle spec (in bundle.md) already has: This REQUIRED file MUST reside in the root of the bundle directory and MUST be named `config.json`. The config.md line may have been useful when it was added (77d44b1, Update runtime.md, 2015-07-16). But since the bundle.md line landed in 106ec2d (Cleanup bundle.md, 2015-10-02, #210), I think it's been redundant. Signed-off-by: W. Trevor King <wking@tremily.us>
Configuration menu - View commit details
-
Copy full SHA for c83bdfb - Browse repository at this point
Copy the full SHA c83bdfbView commit details
Commits on Apr 15, 2017
-
config: Require strictly-positive timeout values
If the timeout value was zero, the hook would always error, and there doesn't seem to be much point to that. And I'm not sure what negative timeouts would mean. By adding this restriction, we do not limit useful hook entries, and we give the validation code grounds to warn users attempting to validate configs which are poorly defined or have useless hook entries. I'd like to remove the pointer from the Go type to comply with our anti-pointer zero-value style (style.md) now that Go's zero-value is clearly invalid. However, there has been maintainer resistance to removing the pointer [1] (although I don't think this is consistent with previous maintainer statements that we don't need pointers when the zero value is invalid [2]). In order to land the normative spec change, this commit keeps the current *int for Hook.Timeout and punts a consistent policy to future work. [1]: #764 (comment) [2]: #653 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Configuration menu - View commit details
-
Copy full SHA for ecf7314 - Browse repository at this point
Copy the full SHA ecf7314View commit details
Commits on Apr 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d417d39 - Browse repository at this point
Copy the full SHA d417d39View commit details -
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
zhouhao committedApr 27, 2017 Configuration menu - View commit details
-
Copy full SHA for 79494b2 - Browse repository at this point
Copy the full SHA 79494b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d1ae7 - Browse repository at this point
Copy the full SHA 11d1ae7View commit details
Commits on May 9, 2017
-
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
zhouhao committedMay 9, 2017 Configuration menu - View commit details
-
Copy full SHA for ea65eb3 - Browse repository at this point
Copy the full SHA ea65eb3View commit details -
config-linux: RFC 2119 wording for oomScoreAdj
The previous wording hinted at, but did not require, this setting to be implemented via oom_score_adj. With the new wording, when proc is mounted at /proc, the container process can check this value by looking at /proc/self/oom_score_adj. Signed-off-by: W. Trevor King <wking@tremily.us>
Configuration menu - View commit details
-
Copy full SHA for e9a39e7 - Browse repository at this point
Copy the full SHA e9a39e7View commit details -
config-linux: RFC 2119 wording for intelRdt
So we can compliance-test runtimes for these settings. Also remove the tutorial, since the kernel docs should provide sufficient documentation on that front. The kernel can be patched if they do not, and we do not include tutorials for other config-linux settings in this spec. The updated example was recommended by Xiaochen to compensate for the removed inline tutorial [1]. [1]: #787 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Configuration menu - View commit details
-
Copy full SHA for b11ade4 - Browse repository at this point
Copy the full SHA b11ade4View commit details -
Merge pull request #783 from q384566678/range-limt
Remove range limit
Configuration menu - View commit details
-
Copy full SHA for 6a17a38 - Browse repository at this point
Copy the full SHA 6a17a38View commit details -
Merge pull request #784 from q384566678/schema-fix
schema: bug fixes
Configuration menu - View commit details
-
Copy full SHA for 70e2637 - Browse repository at this point
Copy the full SHA 70e2637View commit details -
schema: Add 'test' target to the Makefile
And fill in some known-good and known-bad examples. We can make this as detailed as we want, but this commit just adds enough to know that: * The full-file spec examples are valid. * The JSON Schema can distinguish valid examples from invalid JSON. This will help catch JSON Schema typos like those being addressed by [1]. [1]: #784 Signed-off-by: W. Trevor King <wking@tremily.us>
Configuration menu - View commit details
-
Copy full SHA for 0b7efd2 - Browse repository at this point
Copy the full SHA 0b7efd2View commit details -
Merge pull request #787 from wking/intel-rdt-style
config-linux: RFC 2119 wording for intelRdt
Mrunal Patel authoredMay 9, 2017 Configuration menu - View commit details
-
Copy full SHA for 9b4b6d7 - Browse repository at this point
Copy the full SHA 9b4b6d7View commit details -
Merge pull request #786 from q384566678/fix-solaris
config-solaris.md: fix info
Configuration menu - View commit details
-
Copy full SHA for ee87262 - Browse repository at this point
Copy the full SHA ee87262View commit details -
Merge pull request #785 from wking/schema-tests
schema: Add 'test' target to the Makefile
Configuration menu - View commit details
-
Copy full SHA for 8976b0a - Browse repository at this point
Copy the full SHA 8976b0aView commit details -
Merge pull request #781 from wking/oomScoreAdj-rfc-2119
config-linux: RFC 2119 wording for oomScoreAdj
Mrunal Patel authoredMay 9, 2017 Configuration menu - View commit details
-
Copy full SHA for 01ec62d - Browse repository at this point
Copy the full SHA 01ec62dView commit details -
Merge pull request #764 from wking/strictly-positive-timeout
config: Require strictly-positive timeout values
Configuration menu - View commit details
-
Copy full SHA for e1b2e61 - Browse repository at this point
Copy the full SHA e1b2e61View commit details -
Merge pull request #756 from wking/config-drop-filename
config: Drop the redundant config.json filename requirement
Configuration menu - View commit details
-
Copy full SHA for 5a39b39 - Browse repository at this point
Copy the full SHA 5a39b39View commit details -
config: Shift oomScoreAdj from linux.resources to process
The only discussion related to this is in [1,2], where the relationship between oomScoreAdj and disableOOMKiller is raised. But since 429f936 (Adding cgroups path to the Spec, 2015-09-02, #137) resources has been tied to cgroups, and oomScoreAdj is not about cgroups. For example, we currently have (in config-linux.md): You can configure a container's cgroups via the resources field of the Linux configuration. I suggested we move the property from linux.resources.oomScoreAdj to linux.oomScoreAdj so config authors and runtimes don't have to worry about what cgroupsPath means if the only entry in resources is oomScoreAdj. Michael responded with [4]: If anything it should probably go on the process So that's what this commit does. I've gone with the four-space indents here to keep Pandoc happy (see 7795661 (runtime.md: Fix sub-bullet indentation, 2016-06-08, #495), but have left the existing entries in this list unchanged to reduce churn. [1]: #236 [2]: #292 [3]: #137 [4]: #782 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Configuration menu - View commit details
-
Copy full SHA for 0417be6 - Browse repository at this point
Copy the full SHA 0417be6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 99a1b8d363f7b14286cf90ab7a080142182a1399...0417be67c8709fad61f34522b367b4e3e7f80143