Skip to content

Commit 75745d3

Browse files
committed
specs-go/config: Use a pointer for Process.ConsoleSize
Fix: $ go test ./round_trip_test.go --- FAIL: TestConfigRoundTrip (0.00s) --- FAIL: TestConfigRoundTrip/config_1 (0.00s) round_trip_test.go:32: failed to round-trip: {"ociVersion":"1.0.0","platform":{"os":"linux","arch":"amd64"},"process":{"consoleSize":{"height":0,"width":0},"user":{"uid":1,"gid":1},"args":["sh"],"cwd":"/"},"root":{"path":"rootfs"}} FAIL FAIL command-line-arguments 0.003s By using a pointer for this optional struct property. Background on this in [1]. [1]: golang/go#11939 Signed-off-by: W. Trevor King <wking@tremily.us>
1 parent 5a39b39 commit 75745d3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

specs-go/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ type Process struct {
3434
// Terminal creates an interactive terminal for the container.
3535
Terminal bool `json:"terminal,omitempty"`
3636
// ConsoleSize specifies the size of the console.
37-
ConsoleSize Box `json:"consoleSize,omitempty"`
37+
ConsoleSize *Box `json:"consoleSize,omitempty"`
3838
// User specifies user information for the process.
3939
User User `json:"user"`
4040
// Args specifies the binary and arguments for the application to execute.

0 commit comments

Comments
 (0)