runc update: skip devices #2994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runc update CLI is not able to modify devices, so let's set SkipDevices (so that a cgroup controller won't try to update devices cgroup). This helps use cases when some other device management (NVIDIA GPUs) applies its configuration on top of what runc does. Make sure we do not save SkipDevices into state.json. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
cyphar
approved these changes
Jun 4, 2021
Member
cyphar
left a comment
cyphar
left a comment
There was a problem hiding this comment.
LGTM, I think dropping SkipDevices from the state is a good idea regardless of the original issue (and I prefer this to the other PR).
Member
|
Though it should be noted this pretty much invalidates the |
crosbymichael
approved these changes
Jun 4, 2021
Contributor
Author
|
Yes, I am going to remove the test and maybe try to add a unit test. I'd rather do it separately from this PR though. Let's discuss it in there: #3000 |
This was referenced Jun 9, 2021
vasiliy-ul
referenced
this pull request
in kubevirt/kubevirt
Jan 3, 2024
CPU manager periodically updates cgroup settings via the container runtime interface. Runc prior to version v1.0.0 drops all 'custom' cgroup device rules on 'update' and that causes a race with live migration when block volumes are hotplugged. Try to setup the test in a way so that the VMI is migrated to a node without CPU manager. Signed-off-by: Vasiliy Ulyanov <vulyanov@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
runc updateCLI is not able to modify devices (and it is not clearhow to implement that properly), let's set
SkipDevices=true,so that a cgroup controller won't try to update devices cgroup.
This helps use cases when some other device management (NVIDIA GPUs)
applies its configuration on top of what runc does.
Make sure we do not save
SkipDevicesintostate.json.This is an alternative to #2988.
Proposed changelog entry
runc updateno longer updates cgroup devices configuration.