cgroupv1 freezer: thaw to increase freeze chances #2791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that briefly thawing the cgroup while freezing greatly increases its chances to freeze successfully. The test case I used is doing runc exec in a look parallel with runc pause/resume in another loop, and the failure to freeze rate reduced from 40 to 0 per minute (tested inside a VM using a busybox container running sleep 1h, doing about 1500 pause/resumes and 650 execs per minute), with max retries being 150 (of 1000). This is still a game of chances, so failures are possible. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
dqminh
approved these changes
Feb 5, 2021
This was referenced Mar 1, 2021
This was referenced Apr 14, 2021
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2785 and a continuation of #2774, addressing #2753
It appears that briefly thawing the cgroup while freezing
greatly increases its chances to freeze successfully.
The test case I used is doing runc exec in a look parallel with runc
pause/resume in another loop, and the failure to freeze rate reduced
from 40 to 0 per minute (tested inside a VM using a busybox container
running sleep 1h, doing about 1500 pause/resumes and 650 execs per
minute), with max retries being 150 (of 1000).
This is still a game of chances, so failures are possible.
Thanks to @Vanient for idea and initial implementation.
Closes: #2785