Skip to content

Commit fc467b9

Browse files
committed
nsenter: fix clang-tidy warning
nsexec.c:148:3: warning: Initialized va_list 'args' is leaked [clang-analyzer-valist.Unterminated] Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
1 parent b225ef5 commit fc467b9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

libcontainer/nsenter/nsexec.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,11 @@ static void write_log_with_info(const char *level, const char *function, int lin
145145

146146
va_start(args, format);
147147
if (vsnprintf(message, sizeof(message), format, args) < 0)
148-
return;
149-
va_end(args);
148+
goto done;
150149

151-
if (dprintf(logfd, "{\"level\":\"%s\", \"msg\": \"%s:%d %s\"}\n", level, function, line, message) < 0)
152-
return;
150+
dprintf(logfd, "{\"level\":\"%s\", \"msg\": \"%s:%d %s\"}\n", level, function, line, message);
151+
done:
152+
va_end(args);
153153
}
154154

155155
#define write_log(level, fmt, ...) \

0 commit comments

Comments
 (0)