Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Implement ref deleting command #86

Open
hustcat opened this issue Nov 17, 2016 · 3 comments
Open

Proposal: Implement ref deleting command #86

hustcat opened this issue Nov 17, 2016 · 3 comments

Comments

@hustcat
Copy link
Contributor

hustcat commented Nov 17, 2016

Consider a OCI layout contain two refs: v1.0 and v2.0; v1.0 contain layer1, and v2.0 contain layer1 and layer2.

When I delete v2.0, layer2 should be deleted.

@wking
Copy link
Contributor

wking commented Nov 17, 2016

Shallow ref-deletion is handled in #5 with commands like:

$ oci-refs delete image.tar v2.0

On Thu, Nov 17, 2016 at 12:29:30AM -0800, Ye Yin wrote:

Consider a OCI layout contain two refs: v1.0 and v2.0; v1.0
contain layer1, and v2.0 contain layer1 and layer2.

When I delete v2.0, layer2 should be deleted.

It's not quite that simple. For example, perhaps layer2 is part of a
new v3.0 that is being pushed from the bottom up in parallel. In that
case, removing layer2 could break the published v3.0. A more robust
approach is to add a garbage-collection command which somehow protects
from this sort of situation. I've been planning to write one up
if/when #5 lands here, and @cyphar already has an exclusive-lock
mark/sweep implemenation in umoci (cyphar/umoci#17).

@hustcat
Copy link
Contributor Author

hustcat commented Nov 18, 2016

#5 is a great job, I'd like it be merged ASAP:)

@cyphar
Copy link
Member

cyphar commented Jun 22, 2020

This project is no longer actively maintained. However, umoci is a much more full-featured tool for manipulating OCI images, and is now an OCI project as a reference implementation of the OCI image-spec. I would strongly suggest people move to using umoci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants