Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: namespace image-spec labels with "org.opencontainers.image" #600

Closed
stevvooe opened this issue Mar 8, 2017 · 6 comments
Closed

spec: namespace image-spec labels with "org.opencontainers.image" #600

stevvooe opened this issue Mar 8, 2017 · 6 comments
Milestone

Comments

@stevvooe
Copy link
Contributor

stevvooe commented Mar 8, 2017

When labels from images land elsewhere through propagation, it is hard to tell their source. Let's add .image to annotation prefix to make it clear when a label is part of an image.

Please see #492 (comment) for the original issue.

cc @cyphar @vbatts

@stevvooe stevvooe added this to the v1.0.0-rc6 milestone Mar 8, 2017
@cyphar
Copy link
Member

cyphar commented Mar 9, 2017

👍

@vbatts
Copy link
Member

vbatts commented Mar 9, 2017

i like the provenance, though does this include the reference to that image's manifest digest as well?

@jonboulle
Copy link
Contributor

@vbatts hmm, you mean so one can reverse-trace from a runtime-spec config.json to an image?

@vbatts
Copy link
Member

vbatts commented Mar 9, 2017

@jonboulle maybe that too, but not what i was originally thinking. More like "i have ubuntu LTS image (sha256:deadbeefface..), and add my software on top" as only the ubuntu LTS layers stay referenced, but not the original manifest. This would allow a pointer to those objects.

@stevvooe
Copy link
Contributor Author

stevvooe commented Mar 9, 2017

@vbatts This was not intended to go that far. I placed a comment in #424 clarifying the possible link.

I'll create a PR for this one today.

@vbatts
Copy link
Member

vbatts commented Mar 9, 2017

oh oh. this is just an addition onto the prefix, not an .image name. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants