Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: document how to translate image config into runtime config #479

Closed
philips opened this issue Nov 30, 2016 · 7 comments
Closed

config: document how to translate image config into runtime config #479

philips opened this issue Nov 30, 2016 · 7 comments

Comments

@philips
Copy link
Contributor

philips commented Nov 30, 2016

There are several fields in the OCI Image Config that directly translate to a fields on the Runtime Config. We should document how those fields translate.

The obvious ones:

  • User
  • Env
  • Entrypoint
  • Cmd
  • WorkingDir

UX ones (used to help users but not automatically mapped):

  • ExposedPorts
  • Volumes

Optional as they depend on the user and largely shouldn't be dictated by image author:

  • Memory
  • MemorySwap
  • CPUShares
@philips
Copy link
Contributor Author

philips commented Nov 30, 2016

As discussed @wking @stevvooe

@philips
Copy link
Contributor Author

philips commented Nov 30, 2016

@cyphar could you take a swing at adding this language?

@philips philips mentioned this issue Nov 30, 2016
Closed
@wking
Copy link
Contributor

wking commented Dec 1, 2016

See also #454, which would set the required runtime-spec config version.

@cyphar
Copy link
Member

cyphar commented Dec 1, 2016

@philips Yeah, I'll give it a shot.

@wking wking mentioned this issue Dec 7, 2016
Closed
cyphar added a commit to opencontainers/umoci that referenced this issue Dec 10, 2016
@cyphar
image: generator: implement annotation generation to runtime
aa84bb1 
It's important the we set annotations in the resultant runtime config --
otherwise we could be dropping important configuration information. For
some reason this information is duplicated in two places in the
image-spec so we just pick an arbitrary ordering (that will need to be
clarified in a proposal to opencontainers/image-spec#479).

Signed-off-by: Aleksa Sarai <asarai@suse.com>
cyphar added a commit to opencontainers/umoci that referenced this issue Dec 10, 2016
@cyphar
image: generator: implement annotation generation to runtime
1f040af 
It's important the we set annotations in the resultant runtime config --
otherwise we could be dropping important configuration information. For
some reason this information is duplicated in two places in the
image-spec so we just pick an arbitrary ordering (that will need to be
clarified in a proposal to opencontainers/image-spec#479).

Signed-off-by: Aleksa Sarai <asarai@suse.com>
cyphar added a commit to opencontainers/umoci that referenced this issue Dec 10, 2016
@cyphar
image: generator: implement annotation generation to runtime
3da6b85 
It's important the we set annotations in the resultant runtime config --
otherwise we could be dropping important configuration information. For
some reason this information is duplicated in two places in the
image-spec so we just pick an arbitrary ordering (that will need to be
clarified in a proposal to opencontainers/image-spec#479).

Signed-off-by: Aleksa Sarai <asarai@suse.com>
@cyphar cyphar mentioned this issue Dec 12, 2016
Merged
@cyphar
Copy link
Member

cyphar commented Dec 12, 2016

I've done this in #492.

@RobDolinMS
Copy link
Collaborator

@philips Can this Issue be closed with active discussion now happening in PR #492 ?

@stevvooe
Copy link
Contributor

@RobDolinMS We should really wait for the issue to get resolved before closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@philips @stevvooe @wking @cyphar @RobDolinMS