Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manifest] Unclear if "should" intended as "SHOULD" #109

Closed
RobDolinMS opened this issue Jun 1, 2016 · 4 comments
Closed

[Manifest] Unclear if "should" intended as "SHOULD" #109

RobDolinMS opened this issue Jun 1, 2016 · 4 comments

Comments

@RobDolinMS
Copy link
Collaborator

RobDolinMS commented Jun 1, 2016

size int
...
If the length of the retrieved content does not match the specified length, the content should not be trusted.

If intended as a recommendation, use "SHOULD" (ALL CAPS.)
If not intended as a recommendation invoke RFC meaning, consider alternate wording.

@stevvooe
Copy link
Contributor

stevvooe commented Jun 1, 2016

I'm not even sure this is correct. The size is really there to support preallocation. Content verification should be done through digest.

@philips
Copy link
Contributor

philips commented Jun 2, 2016

I think it is correct. This may protect against future length extension attacks.

@stevvooe
Copy link
Contributor

stevvooe commented Jun 2, 2016

Ok, this should be SHOULD, then.

I'm going to add this to #111, as this question comes up all the time.

@philips
Copy link
Contributor

philips commented Jun 15, 2016

confirmed fixed in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants