Skip to content

[stable-4.2] fix: space batch actions not loading in spaces table #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kulmann merged 1 commit into from
Nov 7, 2025
+6 −5
Merged

[stable-4.2] fix: space batch actions not loading in spaces table #1520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-pkg/src/components/FilesList/ResourceTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ export default defineComponent({

const toggleSelection = (resourceId: string) => {
resourcesStore.toggleSelection(resourceId)
emitSelect(resourcesStore.selectedIds)
emitSelect([...resourcesStore.selectedIds])
}

const getResourceLink = (resource: Resource) => {
Expand Down
6 changes: 2 additions & 4 deletions packages/web-pkg/src/components/FilesList/ResourceTiles.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,10 +496,8 @@ const toggleTile = (data: [Resource, MouseEvent | KeyboardEvent], event?: MouseE
}

const toggleSelection = (resource: Resource) => {
const selected = !isResourceSelected(resource)
? [...selectedIds, resource.id]
: selectedIds.filter((id) => id !== resource.id)
emit('update:selectedIds', selected)
resourcesStore.toggleSelection(resource.id)
emit('update:selectedIds', [...resourcesStore.selectedIds])
}

const getResourceCheckboxLabel = (resource: Resource) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/web-pkg/tests/unit/components/FilesList/ResourceTiles.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { useCanBeOpenedWithSecureView } from '../../../../src/composables/resour
import { displayPositionedDropdown } from '../../../../src/helpers/contextMenuDropdown'
import { OcFilterChip } from '@opencloud-eu/design-system/components'
import { ResourceIndicator } from '../../../../src/helpers/statusIndicators'
import { useResourcesStore } from '../../../../src'

vi.mock('../../../../src/helpers/contextMenuDropdown')
vi.mock('../../../../src/composables/viewMode', async (importOriginal) => ({
Expand Down Expand Up @@ -120,6 +121,8 @@ describe('ResourceTiles component', () => {
preventDefault: vi.fn()
} as unknown as MouseEvent

const resourcesStore = useResourcesStore()
resourcesStore.selectedIds = [resources[0].id]
await resourceTile.vm.$emit('click', mockMouseEvent)
expect(wrapper.emitted('update:selectedIds')).toBeTruthy()
expect(wrapper.emitted('update:selectedIds')[0][0]).toEqual([resources[0].id])
Expand Down
Loading