Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vairable changes name 0.5.5 to 0.5.13 and some zeros? #156

Closed
peterdudfield opened this issue Jun 12, 2024 · 5 comments
Closed

vairable changes name 0.5.5 to 0.5.13 and some zeros? #156

peterdudfield opened this issue Jun 12, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Jun 12, 2024

Detailed Description

The variables seems to hange name from 0.5.5 to 0.5.13

Context

  • forecast goes wrong, and we think it was due to nwp change

Old (from 4th June)

  • ukv: ['dlwrf', 'dswrf', 'hcc', 'lcc', 'mcc', 'prate', 'r', 'sde', 'si10',
    't', 'vis', 'wdir10']
    ecmwf: ['tcc', 'dlwrf', 'dswrf', 'duvrs', 'hcc', 'lcc', 'mcc', 'prate',
    'sde', 'sr', 't', 'u10', 'u100', 'u200', 'v10', 'v100', 'v200',
    'vis']

New

  • UKV: ['r', 't', 'vis', 'wdir10', 'si10', 'hcc', 'lcc', 'mcc', 'dlwrf',
    'dswrf', 'prate', 'sde']
  • ECMWF: ['sr', 'duvrs', 'sde', 'clt', 'u10', 'v10', 't', 'dswrf', 'dlwrf',
    'lcc', 'mcc', 'hcc', 'vis', 'u200', 'v200', 'u100', 'v100',
    'prate']

Possible Implementation

  • work out why this is happened?
  • either update NWP-consumer, or update pvnet_app to rename
  • or update ocf_datapipes
@peterdudfield peterdudfield added the bug Something isn't working label Jun 12, 2024
@peterdudfield
Copy link
Contributor Author

tcc seems to be missing from ECMWF in the new one, and possibly renamed as clt?

@peterdudfield
Copy link
Contributor Author

Could be fixed once this is done - openclimatefix/ocf_datapipes#326

Also could be fixed in pvnet_app - https://github.com/openclimatefix/pvnet_app/blob/main/pvnet_app/data.py#L267

@peterdudfield
Copy link
Contributor Author

Found it: In the live ECMWF data, can see that all values are 0 in the second step
Screenshot 2024-06-12 at 14 06 21

@Sukh-P
Copy link
Member

Sukh-P commented Jun 12, 2024

Mentioned this to @devsjc earlier today and I am not sure but these logs look suspicious as they mention renamed variables and says something like "filling missing variables with 0" and has an exception so could be related to that issue

@peterdudfield peterdudfield changed the title vairable changes name 0.5.5 to 0.5.13 vairable changes name 0.5.5 to 0.5.13 and some zeros? Jul 11, 2024
@peterdudfield
Copy link
Contributor Author

I think this is all done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants