fix linting

Author: bilalesi

.pre-commit-config-ci.yaml

@@ -1,7 +1,7 @@
 repos:
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
-  rev: v0.2.2
+  rev: v0.14.2
   hooks:
     # Run the linter.
     - id: ruff

.pre-commit-config.yaml

@@ -2,7 +2,7 @@ default_install_hook_types: [pre-push]
 repos:
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
-  rev: v0.2.2
+  rev: v0.14.2
   hooks:
     # Run the linter.
     - id: ruff

docker-compose.ci.yml

@@ -12,7 +12,7 @@ networks:
 
 services:
   keycloak-db:
-    image: postgres:latest
+    image: postgres:17.6
     container_name: keycloak-db
     environment:
       POSTGRES_USER: keycloak
@@ -58,7 +58,7 @@ services:
       - ./env-prep/realm-export.json:/opt/keycloak/data/import/realm-import.json
 
   virtual-lab-db:
-    image: postgres:latest
+    image: postgres:17.6
     container_name: vlm-db
     environment:
       POSTGRES_USER: vlm

virtual_labs/api.py

@@ -89,9 +89,9 @@ def custom_openapi() -> dict[str, Any]:
         description="API description",
         routes=app.routes,
     )
-    openapi_schema["components"]["schemas"][
-        "HTTPValidationError"
-    ] = VlmValidationError.model_json_schema()
+    openapi_schema["components"]["schemas"]["HTTPValidationError"] = (
+        VlmValidationError.model_json_schema()
+    )
 
     app.openapi_schema = openapi_schema
     return app.openapi_schema

virtual_labs/domain/project.py

@@ -28,9 +28,9 @@ class ProjectBody(BaseModel):
     name: Annotated[
         str, StringConstraints(strip_whitespace=True, min_length=1, max_length=250)
     ]
-    description: Optional[
-        Annotated[str, StringConstraints(strip_whitespace=True)]
-    ] = None
+    description: Optional[Annotated[str, StringConstraints(strip_whitespace=True)]] = (
+        None
+    )
 
 
 class ProjectUpdateBody(BaseModel):
@@ -41,9 +41,9 @@ class ProjectUpdateBody(BaseModel):
             str, StringConstraints(strip_whitespace=True, min_length=1, max_length=250)
         ]
     ] = None
-    description: Optional[
-        Annotated[str, StringConstraints(strip_whitespace=True)]
-    ] = None
+    description: Optional[Annotated[str, StringConstraints(strip_whitespace=True)]] = (
+        None
+    )
 
 
 class Project(BaseModel):

virtual_labs/repositories/subscription_repo.py

@@ -133,17 +133,15 @@ async def list_subscriptions(
         user_id: Optional[UUID] = None,
         status: Optional[SubscriptionStatus] = None,
         subscription_type: Literal["free"] = "free",
-    ) -> list[FreeSubscription]:
-        ...
+    ) -> list[FreeSubscription]: ...
 
     @overload
     async def list_subscriptions(
         self,
         user_id: Optional[UUID] = None,
         status: Optional[SubscriptionStatus] = None,
         subscription_type: Literal["paid"] = "paid",
-    ) -> list[PaidSubscription]:
-        ...
+    ) -> list[PaidSubscription]: ...
 
     async def list_subscriptions(
         self,

virtual_labs/tests/integration/test_lab_project_management.py

@@ -164,9 +164,9 @@ async def created_project(
         headers=headers,
     )
 
-    assert (
-        project_response.status_code == HTTPStatus.OK
-    ), f"Failed to create project: {project_response.text}"
+    assert project_response.status_code == HTTPStatus.OK, (
+        f"Failed to create project: {project_response.text}"
+    )
 
     project_id = project_response.json()["data"]["project"]["id"]
     async with session_context_factory() as session:
@@ -388,6 +388,8 @@ async def test_attach_users_initial_success(
         response_data = attach_response.json()["data"]
 
         # Assert response structure
+        # test-1 is already a project admin (added during project creation as VL admin)
+        # so only test-2 gets added as member
         assert len(response_data["added_users"]) == 1
         assert len(response_data["updated_users"]) == 0
         assert len(response_data["failed_operations"]) == 0
@@ -396,7 +398,7 @@ async def test_attach_users_initial_success(
         added_user_ids_roles = {
             u["id"]: u["role"] for u in response_data["added_users"]
         }
-        assert added_user_ids_roles[user_ids["test-1"]] == "admin"
+        # Only test-2 should be in added_users as member
         assert added_user_ids_roles[user_ids["test-2"]] == "member"
 
         proj_admins = await gqr.a_retrieve_group_user_ids(proj_admin_group_id)

virtual_labs/usecases/bookmarks/get_bookmarks_by_category.py

@@ -20,9 +20,9 @@ async def get_bookmarks_by_category(
         repo = BookmarkQueryRepository(db)
         db_bookmarks = await repo.get_project_bookmarks(project_id, category)
 
-        grouped_bookmarks: defaultdict[
-            BookmarkCategory, list[BookmarkOut]
-        ] = defaultdict(list)
+        grouped_bookmarks: defaultdict[BookmarkCategory, list[BookmarkOut]] = (
+            defaultdict(list)
+        )
 
         for db_bookmark in db_bookmarks:
             grouped_bookmarks[BookmarkCategory(db_bookmark.category)].append(