Skip to content

Add BPAP validation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 30, 2025
Merged

Add BPAP validation #16

merged 17 commits into from
May 30, 2025

Conversation

AurelienJaquier
Copy link
Collaborator

  • also update validation output to have name and validation_details in it

@AurelienJaquier AurelienJaquier self-assigned this May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 17.04545% with 146 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bluecellulab/analysis/analysis.py 16.18% 145 Missing ⚠️
bluecellulab/analysis/utils.py 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
bluecellulab/analysis/utils.py 66.66% <66.66%> (ø)
bluecellulab/analysis/analysis.py 34.09% <16.18%> (-65.91%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AurelienJaquier AurelienJaquier requested a review from ilkilic May 27, 2025 15:20
ilkilic
ilkilic previously approved these changes May 28, 2025
@darshanmandge
Copy link
Collaborator

Thanks @AurelienJaquier! Does the BPAP function not plot the actual recordings vs time plot for different distances?
Users would like to see the shape of bAPs at different distances.

@AurelienJaquier
Copy link
Collaborator Author

Thanks @AurelienJaquier! Does the BPAP function not plot the actual recordings vs time plot for different distances? Users would like to see the shape of bAPs at different distances.

Sure, I can do that

darshanmandge
darshanmandge previously approved these changes May 30, 2025
Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@AurelienJaquier AurelienJaquier merged commit 4151479 into main May 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants