Skip to content

Commit d3e8b85

Browse files
committed
Merge branch 'sh_eth-fixes'
Sergei Shtylyov says: ==================== sh_eth: fix bugs in sh_eth_ring_init() Here's a set of 2 patches against DaveM's 'net.git' repo which fix couple of bugs in the sh_eth_ring_init() function. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
2 parents 615a100 + b61ed8f commit d3e8b85

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/net/ethernet/renesas/sh_eth.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1212,15 +1212,15 @@ static int sh_eth_ring_init(struct net_device *ndev)
12121212
mdp->rx_buf_sz += NET_IP_ALIGN;
12131213

12141214
/* Allocate RX and TX skb rings */
1215-
mdp->rx_skbuff = kmalloc_array(mdp->num_rx_ring,
1216-
sizeof(*mdp->rx_skbuff), GFP_KERNEL);
1215+
mdp->rx_skbuff = kcalloc(mdp->num_rx_ring, sizeof(*mdp->rx_skbuff),
1216+
GFP_KERNEL);
12171217
if (!mdp->rx_skbuff) {
12181218
ret = -ENOMEM;
12191219
return ret;
12201220
}
12211221

1222-
mdp->tx_skbuff = kmalloc_array(mdp->num_tx_ring,
1223-
sizeof(*mdp->tx_skbuff), GFP_KERNEL);
1222+
mdp->tx_skbuff = kcalloc(mdp->num_tx_ring, sizeof(*mdp->tx_skbuff),
1223+
GFP_KERNEL);
12241224
if (!mdp->tx_skbuff) {
12251225
ret = -ENOMEM;
12261226
goto skb_ring_free;
@@ -1232,7 +1232,7 @@ static int sh_eth_ring_init(struct net_device *ndev)
12321232
GFP_KERNEL);
12331233
if (!mdp->rx_ring) {
12341234
ret = -ENOMEM;
1235-
goto desc_ring_free;
1235+
goto skb_ring_free;
12361236
}
12371237

12381238
mdp->dirty_rx = 0;

0 commit comments

Comments
 (0)