Skip to content

Commit a628e6c

Browse files
ShawnCLeegregkh
authored andcommitted
drm/i915/dp: return proper DPRX link training result
commit 9af4bf2 upstream. After DPRX link training, intel_dp_link_train_phy() did not return the training result properly. If link training failed, i915 driver would not run into link train fallback function. And no hotplug uevent would be received by user space application. Fixes: b30edfd ("drm/i915: Switch to LTTPR non-transparent mode link training") Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Cc: Imre Deak <imre.deak@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Cooper Chiou <cooper.chiou@intel.com> Cc: William Tseng <william.tseng@intel.com> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210706152541.25021-1-shawn.c.lee@intel.com (cherry picked from commit dab1b47) Signed-off-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 80e336d commit a628e6c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/i915/display/intel_dp_link_training.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ intel_dp_link_train_all_phys(struct intel_dp *intel_dp,
848848
}
849849

850850
if (ret)
851-
intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
851+
ret = intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
852852

853853
if (intel_dp->set_idle_link_train)
854854
intel_dp->set_idle_link_train(intel_dp, crtc_state);

0 commit comments

Comments
 (0)