mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE()

d4ddi0 · torvalds · commit 543dfb2df8eb · 2016-01-14T16:00:49.000-08:00
Running sparse on drivers/staging/lustre results in dozens of warnings:
include/linux/gfp.h:281:41: warning: odd constant _Bool cast (400000
becomes 1)

Use "!!" to explicitly convert to bool and get rid of the warning.

Signed-off-by: Joshua Clayton &lt;stillcompiling@gmail.com&gt;
Cc: Mel Gorman &lt;mgorman@techsingularity.net&gt;
Cc: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/include/linux/gfp.h b/include/linux/gfp.h
@@ -278,7 +278,7 @@ static inline int gfpflags_to_migratetype(const gfp_t gfp_flags)
 
 static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags)
 {
-	return (bool __force)(gfp_flags & __GFP_DIRECT_RECLAIM);
+	return !!(gfp_flags & __GFP_DIRECT_RECLAIM);
 }
 
 #ifdef CONFIG_HIGHMEM

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ static inline int gfpflags_to_migratetype(const gfp_t gfp_flags)`
`278`	`278`
`279`	`279`	`static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags)`
`280`	`280`	`{`
`281`		`- return (bool __force)(gfp_flags & __GFP_DIRECT_RECLAIM);`
	`281`	`+ return !!(gfp_flags & __GFP_DIRECT_RECLAIM);`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`#ifdef CONFIG_HIGHMEM`