Skip to content

Commit 0c7b4e0

Browse files
Amitkumar Karwargregkh
authored andcommitted
mwifiex: avoid memsetting PCIe event buffer
commit 14d9c11 upstream. Preallocated PCIe buffer is being reused for all PCIe interface events. Physical address of the buffer is shared with firmware so that it can perform DMA on it. As event length is specified in the header, there should not be a problem if the buffer gets overwritten. We will save some cycles by avoiding memset everytime while submitting the buffer to firmware. Fixes: 2728cec(mwifiex: corrections in PCIe event skb) Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a251acf commit 0c7b4e0

File tree

1 file changed

+0
-1
lines changed
  • drivers/net/wireless/mwifiex

1 file changed

+0
-1
lines changed

drivers/net/wireless/mwifiex/pcie.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1815,7 +1815,6 @@ static int mwifiex_pcie_event_complete(struct mwifiex_adapter *adapter,
18151815
if (!card->evt_buf_list[rdptr]) {
18161816
skb_push(skb, INTF_HEADER_LEN);
18171817
skb_put(skb, MAX_EVENT_SIZE - skb->len);
1818-
memset(skb->data, 0, MAX_EVENT_SIZE);
18191818
if (mwifiex_map_pci_memory(adapter, skb,
18201819
MAX_EVENT_SIZE,
18211820
PCI_DMA_FROMDEVICE))

0 commit comments

Comments
 (0)