-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label photos with party, house #1410
Comments
I thought briefly about the case where a person changes parties. It might be possible to show what they were at the time of the relevant votes, but that is silly gold plating IMHO and just showing each person's current party would be more than sufficient in reality, so I'm declaring such embellishments out of scope for at least the initial version of this feature request of mine. A viable alternative might be to show past parties crossed and/or greyed out behind and a bit offset from the more recent, and the current one fully opaque in front. So, as suggested, this could theoretically be implemented purely by updating the images and not altering the code at all (though there is also definitely something to be said for adding the labels in code at run time!) |
(I'd attempt to contribute code, but I've never done ruby. I'm sort of guessing it would happen in the person.rb file in the 3 show_[size]_image defs???) |
This is related to the discussion on #1092 |
This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you! |
This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you! |
Registered party logos (in small black and white form at least) are visible at https://www.aec.gov.au/parties_and_representatives/party_registration/Registered_parties/ |
This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you! |
This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you! |
This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you! |
I think this would be useful especially when seeing who voted how on the policies pages, but it would also be useful wherever a face is shown (or even a placeholder). I for one do not recognise each polly by face, and outside my own electorate mostly only care about what party they are. A label/logo perhaps on the bottom left of each photo for LNP/Labour/Green/Independent etc. (or leave blank for independent) would make this info immediately apparent on first scan.
Secondary to the party is the house. While the background colour of the photos shows who are reps vs. senate once you know to look for it, a colour key would be useful, or else a simple label in the corner (S or R, perhaps).
The text was updated successfully, but these errors were encountered: