Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Expose Prometheus metrics #355

Open
guidoiaquinti opened this issue Dec 5, 2017 · 6 comments
Open

Expose Prometheus metrics #355

guidoiaquinti opened this issue Dec 5, 2017 · 6 comments

Comments

@guidoiaquinti
Copy link

It would be good to integrate the Prometheus client library to expose Orchestrator metrics like we already do for graphite.

I know that we expose the same metrics in expvar-like format via /debug/metrics but that's not exactly Prometheus compatible (see related discussion in the gh-ost repo).

I'm opening this issue to keep track of this enhancement.

Thank you!

@shlomi-noach
Copy link
Collaborator

@guidoiaquinti are you suggesting to add promotheus metrics? Otherwise how should this be done?

@guidoiaquinti
Copy link
Author

My suggestion is to add an HTTP route (e.g. /metrics) that can expose Orchestrator metrics in a Prometheus compatible format.

Here's a list of some third-party software natively exposing metrics in the Prometheus format.

@shlomi-noach
Copy link
Collaborator

@guidoiaquinti thanks :) I meant to ask whether you intend to implements us or want us to.

I'm not familiar with promotheus and this isn't on my immediate roadmap; given that I'll need to invest learning promotheus/metrics, I'm unlikely to do this in the near future.

@guidoiaquinti
Copy link
Author

Sorry for the misunderstanding @shlomi-noach 😄

I've opened this issue only to keep track of the enhancement. I don't think I'll have time in the near future to implement it and it's currently not a high-pri for us.

@shlomi-noach
Copy link
Collaborator

Cool. Thank you!

@ameetkotian
Copy link

PR for review #1414

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants