Handle negative numeric enum values #1601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
append
ValueMinus
string to enum member names starting with a-
, if a name is not explicitly providedcreate negative numeric enum member values using
ts.factory.createPrefixUnaryExpression()
Previous behavior:
When there is no name explicitly provided for them, numeric enum member names are constructed by prefixing the number with a
Value
stringThe code did not take negative numbers into account, which resulted in enum members like:
Context
Negative numeric enum members are not unusual in C# projects, and when combined with tools autogenerating OpenAPI schemas (i.e. Swashbuckle, NSwag), it is easy to hit the issue mentioned above.
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)