feat: Always generate enums with sorted members #728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code generator always renders the enum members in alphabetical order so that to minimise the changes in the generated code.
Tl;RL
Previously the enum members were collected as a dictionary in a random order and rendered as is, this was causing multiple run of the code generator to render the enum members in different order. If the generated code is then committed in a VCS it would create unnecessary changes because of the different order of the semantically same enum definition.
With this change the enum members are always rendered in alphabetical order so enums that are semantically the same will be rendered also the same in the code.